Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect config element diagnostic with versionless feature #335

Open
cherylking opened this issue Jan 13, 2025 · 3 comments · May be fixed by #341
Open

Incorrect config element diagnostic with versionless feature #335

cherylking opened this issue Jan 13, 2025 · 3 comments · May be fixed by #341
Assignees

Comments

@cherylking
Copy link
Member

This mpMetrics config element should not have a diagnostic since the versionless mpMetrics feature is specified.

Screenshot 2025-01-13 at 10 31 28 AM

@cherylking
Copy link
Member Author

The quick fix shows the following:

Screenshot 2025-01-13 at 10 33 08 AM

@arunvenmany-ibm arunvenmany-ibm self-assigned this Jan 16, 2025
@arunvenmany-ibm
Copy link
Contributor

arunvenmany-ibm commented Jan 28, 2025

Hi @cherylking

I think the problem is with the featurelist xsd. For mpMetrics enabledBy is always coming as empty
We are getting diagnostic problem even after we add mpMetrics feature(versioned or versionless)

Image

Whereas httpEndpoint is working fine with only versionless feature servlet.

Image

Image

Will debug further to check the issue

Also, do you think we need to add versionless feature in add feature completion ?
Currently, no versionless feature is configured as enabledBy for any configElement in xsd

@arunvenmany-ibm
Copy link
Contributor

Found the issue.
Its because the featurename and configElement name are same and this was causing some incorrect map overwriting nodes map

Image

Due to this, enabledBy list is coming empty for mpMetrics, causing it to never resolve with mpMetrics features

Image

@arunvenmany-ibm arunvenmany-ibm linked a pull request Jan 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants