Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify the issues with platformVersion when updating IntelliJ from version 2024.1.7 to 2024.2. #1220

Closed
vaisakhkannan opened this issue Jan 10, 2025 · 2 comments
Labels
duplicate This issue or pull request already exists should-fix
Milestone

Comments

@vaisakhkannan
Copy link
Contributor

Identify the exact issues with platformVersion when updating IntelliJ from version 2024.1.7 to 2024.2. We found that unit tests fail in IntelliJ version 2024.2 when platformVersion is set to 2024.2 #1048. Investigate other potential issues and check if any deprecation fixes are required mainly to resolve unit test failure. If no solution is found, explore the possibility of running the unit tests on version 2024.1.7 while using platformVersion 2024.2 for building the project and generating the ZIP file.

@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Jan 13, 2025

I tried updating the version from 2024.1.7 to 2024.2 and built the project. However, I encountered same unit test failure as mentioned in the issue #1048. The failure pointed to a specific line of code located in the BaseJakartaTest class, which extends the MavenImportingTestCase class. The line invokes the method importProjectsAsync(pomFiles.toArray(VirtualFile[]::new), continuation), which is defined in the MavenImportingTestCase class.

protected suspend fun importProjectsAsync(vararg files: VirtualFile) {
    importProjectsAsync(listOf(*files))
  }

  protected open suspend fun importProjectsAsync(files: List<VirtualFile>) {
    if (preimportTestMode) {
      val activity = ProjectImportCollector.IMPORT_ACTIVITY.started(project)
      try {
        MavenProjectStaticImporter.getInstance(project)
          .syncStatic(files, null, mavenImporterSettings, mavenGeneralSettings, true, SimpleStructureProjectVisitor(), activity, true)
      }
      finally {
        activity.finished()
      }


    }
    else {
      initProjectsManager(false)
      projectsManager.addManagedFilesWithProfiles(files, MavenExplicitProfiles.NONE, null, null, true)
    }

    IndexingTestUtil.suspendUntilIndexesAreReady(project)
  }

When I reviewed the code for importProjectsAsync(), I noticed some changes in the method. I am attaching the code differences between versions 2024.1.7 and 2024.2

Screenshot 2025-01-13 at 10 47 14 AM

There are two additional parameters present in the code built using version 2024.2

@dessina-devasia
Copy link
Contributor

Closing this issue as it is duplicate of #1048

@github-project-automation github-project-automation bot moved this from New Issues to Sprint Closed in Open Liberty Developer Experience Jan 14, 2025
@dessina-devasia dessina-devasia added the duplicate This issue or pull request already exists label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists should-fix
Projects
Development

No branches or pull requests

2 participants