Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra rework for issue 1202 #1235

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Extra rework for issue 1202 #1235

merged 3 commits into from
Jan 23, 2025

Conversation

turkeylurkey
Copy link
Member

Fixes #1234

Three code improvements were suggested in the review of issue #1202.

  1. Return this instead of calling getInstance()
  2. Synchronize access to libertyModules in addLibertyModule()
  3. Use an enum instead of Strings for project type in the area of Liberty actions. Using an enum allows us to remove some string checking code that is no longer required. This affects a lot of files but it makes the code more robust.

@turkeylurkey turkeylurkey self-assigned this Jan 17, 2025
mrglavas
mrglavas approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

vaisakhkannan
vaisakhkannan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good , Thanks @turkeylurkey

@turkeylurkey turkeylurkey merged commit 98517b1 into OpenLiberty:main Jan 23, 2025
3 checks passed
@turkeylurkey turkeylurkey deleted the issue-1234 branch January 23, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaisakhkannan vaisakhkannan vaisakhkannan approved these changes

@mrglavas mrglavas mrglavas approved these changes

@TrevCraw TrevCraw Awaiting requested review from TrevCraw

@anusreelakshmi934 anusreelakshmi934 Awaiting requested review from anusreelakshmi934

Assignees

@turkeylurkey turkeylurkey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronize access to Liberty Modules singleton
3 participants
@turkeylurkey @mrglavas @vaisakhkannan