Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle situation when there is no terminal tab to close #1240

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Handle situation when there is no terminal tab to close #1240

merged 1 commit into from
Jan 23, 2025

Conversation

turkeylurkey
Copy link
Member

Fixes #1238

Add a try/catch block to handle the case where there is no terminal to be found. Just give up and return.

@turkeylurkey turkeylurkey self-assigned this Jan 22, 2025
mrglavas
mrglavas approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

vaisakhkannan
vaisakhkannan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @turkeylurkey

dessina-devasia
dessina-devasia approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@turkeylurkey
Copy link
Member Author

I reran the failing test runs on the fork and they passed there so I'm going to go ahead and merge.
Mac failure here:
GradleSingleModMPSIDProjectTest > testStartWithParamsActionUsingSearch() FAILED
org.opentest4j.AssertionFailedError: testStartWithParamsActionUsingSearch:validateLibertyServerStopped: Exit. Timed out waiting for message CWWKE0036I
Windows failure here:
GradleSingleModMPSIDProjectTest > testRunTestsActionUsingSearch() FAILED
org.opentest4j.AssertionFailedError: testRunTestsActionUsingSearch:validateProjectStarted: Timed out while waiting for project with resource URI api/resourceand port 9080 to become available.

@turkeylurkey turkeylurkey merged commit c357daa into OpenLiberty:main Jan 23, 2025
1 of 3 checks passed
@turkeylurkey turkeylurkey deleted the issue-1238 branch January 23, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaisakhkannan vaisakhkannan vaisakhkannan approved these changes

@dessina-devasia dessina-devasia dessina-devasia approved these changes

@mrglavas mrglavas mrglavas approved these changes

@TrevCraw TrevCraw Awaiting requested review from TrevCraw

@anusreelakshmi934 anusreelakshmi934 Awaiting requested review from anusreelakshmi934

Assignees

@turkeylurkey turkeylurkey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in automated test when terminal is not open
4 participants
@turkeylurkey @mrglavas @vaisakhkannan @dessina-devasia