Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic missing for @PositiveOrZero #781

Closed
1 task done
turkeylurkey opened this issue May 27, 2024 · 1 comment
Closed
1 task done

Diagnostic missing for @PositiveOrZero #781

turkeylurkey opened this issue May 27, 2024 · 1 comment
Assignees
@vaisakhkannan
Labels
bug Something isn't working should-fix
Milestone
24.0.6

Comments

@turkeylurkey
Copy link
Member

turkeylurkey commented May 27, 2024 •
edited by TrevCraw
Loading

Description:

When using @PositiveOrZero on a List<String> I expect a diagnostic message.
image

When you spell it @PostiveOrZero it does not compile but the diagnostic and quick fix are generated.
image

Specification:

@PositiveOrZero annotation can only be used on BigDecimal, BigInteger, byte, short, int, long, float, double (and their respective wrappers) type fields or methods.

  • Must also enable the unit test in BeanValidationTest.java line 157
@turkeylurkey
Copy link
Member Author

c.f. eclipse/lsp4jakarta#524

@turkeylurkey turkeylurkey mentioned this issue May 27, 2024
Open
5 tasks
@turkeylurkey turkeylurkey added the bug Something isn't working label May 27, 2024
@TrevCraw TrevCraw added this to the 24.0.6 milestone May 28, 2024
@vaisakhkannan vaisakhkannan self-assigned this May 29, 2024
@vaisakhkannan vaisakhkannan mentioned this issue May 29, 2024
Merged
TrevCraw added a commit that referenced this issue May 29, 2024
@TrevCraw
Merge pull request #785 from vaisakhkannan/#781-Diagnostic-Fix-@Posit…
61029dc 
…iveOrZero

Fix  Diagnostic missing for @PositiveOrZero and enabled test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaisakhkannan vaisakhkannan

Labels
bug Something isn't working should-fix
Projects
Open Liberty Developer Experience
Archived in project
Milestone
24.0.6
Development

No branches or pull requests
3 participants
@TrevCraw @turkeylurkey @vaisakhkannan