Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundled header #20

Open
mpreisler opened this issue Jun 5, 2018 · 1 comment
Open

bundled header #20

mpreisler opened this issue Jun 5, 2018 · 1 comment

Comments

@mpreisler
Copy link
Member

test/unit/catch.hpp is a boost header, please consider including the header from boost instead of including it in your project. Bundling is a big red flag for downstream distribution, Fedora, Debian, RHEL and others all have rules against it.

@matejak
Copy link
Collaborator

matejak commented Jun 6, 2018

I don't think that it is a boost header - it is a single-header library and I can't find it in the latest Boost release tarball. It uses a Boost license though.
catch.hpp and acutest.h are not installed and just used when building unittests, do you think that they can really cause problems in distributions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants