Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Add API for Quick Marking via Tasker #2031

Closed
tch123 opened this issue Dec 19, 2024 · 4 comments · Fixed by #2032
Closed

Request to Add API for Quick Marking via Tasker #2031

tch123 opened this issue Dec 19, 2024 · 4 comments · Fixed by #2032
Assignees
Labels
enhancement New feature or request

Comments

@tch123
Copy link

tch123 commented Dec 19, 2024

Description:

As a user, I would like to be able to quickly mark locations using Tasker, especially during recording. This would significantly enhance the convenience of operation during outdoor activities, particularly in the cold winter while wearing gloves.

Feature Request:

Functionality:

Add an API or feature that allows Tasker to trigger a quick marking of the current location during recording.

Use Case:

After starting a recording, users can use a Tasker shortcut (like volume keys) to quickly mark the current location.

Expected Outcome:

Users should be able to create a marker at their current location during recording by calling the API through Tasker.
The marking operation should be simple and quick, capable of being triggered by physical buttons (like volume keys) to accommodate operations while wearing gloves.

Additional Information:

The current version of the API does not seem to be designed for this use case, but this would be a very useful extension.
If possible, I hope this feature can be implemented soon to meet the needs of users during outdoor activities.
Thank you to the development team for considering this feature request!

@dennisguse
Copy link
Member

For the new marker:

  1. Should there be additional data stored (available is already time and location as well as to which track it will belong)?
  2. Should it be created (aka persisted to storage) or
  3. Should the UI be opened, so it will be stored when the user presses (but he can add more data himself)?

@dennisguse
Copy link
Member

Notes to myself:

  • Marker creation is currently triggered by TrackRecordingActivity while persisting is handled by MarkerEditActivity
  • TrackRecordingService is only used to fetch last known location
  • PublicAPI (as of now) has only access to TrackRecordingService

@dennisguse dennisguse self-assigned this Dec 19, 2024
@tch123
Copy link
Author

tch123 commented Dec 19, 2024

  1. I believe the current data (time, location, and track affiliation) is sufficient to describe the marker in detail.

  2. Given my use case involves quickly creating markers, I prefer the method of direct creation (the marker name could be 'Marker 1', 'Marker 2', etc., which can be edited later). However, if there's an option or a separate method to open the UI for editing, that would be even better.

@dennisguse
Copy link
Member

@tch123 Have fun playing around: #2032
Completely untested...

dennisguse added a commit that referenced this issue Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants