Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent QML module versions across the codebase #71

Open
coderabbitai bot opened this issue Dec 26, 2024 · 0 comments
Open

Inconsistent QML module versions across the codebase #71

coderabbitai bot opened this issue Dec 26, 2024 · 0 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2024

We identified inconsistent module versions in QML files (QtQuick, QtQuick.Controls, QtQuick.Layouts, org.kde.kirigami). This issue is to track their standardization in the repository. \n\nReferences:\n- Pull Request: https://github.com/OpenVoiceOS/ovos-gui/pull/70\n- Comment: https://github.com/OpenVoiceOS/ovos-gui/pull/70#discussion_r1898138474\n\n@JarbasAl

💡 Codebase verification

Inconsistent module versions detected across QML files

The codebase shows varying versions for the same Qt modules across different files:

  • QtQuick: varies between 2.4, 2.9, and 2.12
  • QtQuick.Controls: varies between 2.0 and 2.12
  • QtQuick.Layouts: varies between 1.4 and 1.12
  • org.kde.kirigami: varies between 2.4, 2.10, and 2.11

Specific files with newer versions that could guide standardization:

  • SYSTEM_Loading.qml, SYSTEM_Status.qml, FeatureRequest.qml: Using QtQuick 2.12, QtQuick.Controls 2.12
  • RequestHandler.qml: Using QtQuick.Layouts 1.12
  • SYSTEM_UrlFrame.qml: Using Kirigami 2.11

Consider updating all QML files to use these newer, consistent versions to ensure compatibility and maintainability.

🔗 Analysis chain

Use consistent import versions for better maintenance.
All imports are pinned to specific versions except for QtQuick (which uses version 2.4). Verify if version alignment is needed across all QML modules to avoid potential compatibility issues.

Run a quick sanity check to confirm a consistent and supported set of module versions:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for all import statements, making sure we consistently use versions.
rg 'import QtQuick' -A 2
rg 'import QtQuick.Controls' -A 2
rg 'import org.kde.kirigami' -A 2

Length of output: 10308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant