Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: intersperse_blank_char method uses pad character instead of pad_id #11

Closed
coderabbitai bot opened this issue Jan 19, 2025 · 0 comments
Closed
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2025

In the intersperse_blank_char method of TTSTokenizer class, char_to_use incorrectly uses self.characters.pad instead of self.characters.pad_id when use_blank_char is False.

This issue is being tracked but not fixed immediately to maintain alignment with coqui-TTS upstream code.

Current code:

char_to_use = self.characters.blank_id if use_blank_char else self.characters.pad

Expected code:

char_to_use = self.characters.blank_id if use_blank_char else self.characters.pad_id

Originally discovered in: //pull/10#discussion_r1921417115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant