Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EpicEditor.prototype.unload fails in an iframe #400

Open
tansongyang opened this issue Sep 1, 2016 · 0 comments
Open

EpicEditor.prototype.unload fails in an iframe #400

tansongyang opened this issue Sep 1, 2016 · 0 comments

Comments

@tansongyang
Copy link

  1. Create a page that uses EpicEditor. Make sure you call unload.
  2. Load that page in an iframe.

You will get an error because of this line:

editor = window.parent.document.getElementById(self._instanceId);

This seems like a bug. Is there any reason to be calling window.parent here? Even in the first commit, this line was there, yet there were no other calls to window.parent. Everything works fine with just window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant