Enabling dark mode #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed height assigned and then it auto adjusts the div container...
Setting Navbar a different background image named "bg.png" using CSS property(Pseudo selector) for a better UI and adjusting fonts, logo and color
…olor in addition with an attribute to change opacity. Changes this to RBGA instead of RGB, RBGA expects an alpha value that represents opacity and changed the opacity value to a decimal. You can use percentages for RGB/RGBA opacities, but it can cause issues for some browsers, which is why I changed it to the decimal equivalent of 95%. Changed some minor formatting to improve readability
Dark mode addition to website.
thatrobotdev
requested changes
Nov 1, 2021
There was a problem hiding this comment.
Nice, it looks good so far! I think we can go and improve the events/footer section later, I can take a look!
I made some minor change suggestions, mostly based on extra newlines / clarifying comments in some places.
For now, if you resolve any merge conflicts and fix those changes, I'll take another look and then merge it :D. Thank you so much!
Comment on lines
+1
to
+3
| { | ||
| "liveServer.settings.port": 5501 | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| "liveServer.settings.port": 5501 | |
| } |
I think vscode just added this for whatever reason, you can delete it.
Comment on lines
+21
to
+22
|
|
||
|
|
Comment on lines
+30
to
+34
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Comment on lines
+58
to
+71
|
|
||
| /*a.main {*/ | ||
| /* background-color: #E07A5F;*/ | ||
| /* color: #3D405B;*/ | ||
| /* font-family: 'Times New Roman', Times, serif;*/ | ||
| /* border-radius: 10pt 10pt 10pt 10pt;*/ | ||
| /* padding: 10pt;*/ | ||
| /* font-size: 3vw;*/ | ||
| /* text-decoration: none;*/ | ||
| /* transition: padding 1s;*/ | ||
| /* overflow: hidden;*/ | ||
| /* box-shadow: 2px 2px #3D405B;*/ | ||
| /*}*/ | ||
|
|
There was a problem hiding this comment.
Suggested change
| /*a.main {*/ | |
| /* background-color: #E07A5F;*/ | |
| /* color: #3D405B;*/ | |
| /* font-family: 'Times New Roman', Times, serif;*/ | |
| /* border-radius: 10pt 10pt 10pt 10pt;*/ | |
| /* padding: 10pt;*/ | |
| /* font-size: 3vw;*/ | |
| /* text-decoration: none;*/ | |
| /* transition: padding 1s;*/ | |
| /* overflow: hidden;*/ | |
| /* box-shadow: 2px 2px #3D405B;*/ | |
| /*}*/ | |
|
|
||
| /* Setting Navbar a different background image using Pseudoselector named "bg.png" for a better UI and adjusting fonts, logo and color */ | ||
|
|
||
|
|
| text-align: left; | ||
| } | ||
|
|
||
| /* hmaburger setup */ |
There was a problem hiding this comment.
Suggested change
| /* hmaburger setup */ | |
| /* hamburger setup */ |
Comment on lines
+361
to
+363
|
|
||
|
|
||
|
|
Comment on lines
+370
to
+374
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Comment on lines
+379
to
+382
|
|
||
|
|
||
|
|
||
|
|
Comment on lines
+408
to
+411
|
|
||
|
|
||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dark mode addition, but there is an issue that can't apply dark mode to 'events' and "footer" section.
Please look into it and review the rest added..