Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Item Upgrade using nbt tags #175

Open
DevDyna opened this issue Oct 27, 2023 · 2 comments
Open

[Enhancement] Item Upgrade using nbt tags #175

DevDyna opened this issue Oct 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@DevDyna
Copy link

DevDyna commented Oct 27, 2023

[like Thermal compounds on Thermal machines]
Add custom nbt tags to allow the creation of custom upgrades based on src/main/java/net/p3pp3rf1y/sophisticatedcore/upgrades without need to code to add custom

Example create stack tiers with custom sizes only adding on any item {Upgrade:{type:"stack",proprierties:{tier:24}}

@P3pp3rF1y
Copy link
Owner

I can only see this applicable to stack upgrades really because they seem to be the only ones who don't expose one of their properties like this. I guess I could potentially do something like this for them, just don't see a huge reason for that unless you have ideas for how this would be useful / what is being blocked by current state.

@P3pp3rF1y P3pp3rF1y added the enhancement New feature or request label Oct 29, 2023
@DevDyna
Copy link
Author

DevDyna commented Oct 29, 2023

I agree that can break too many stuff without any good reason and it was why i only specified on example the stack upgrades
(because i didn't know if can be too huge or not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants