From 08c22c5f4931697ffa078c5aa8065d373f60a516 Mon Sep 17 00:00:00 2001 From: Blackfaded Date: Mon, 18 Nov 2024 09:00:45 +0100 Subject: [PATCH 1/5] chore: update node to 23 --- .github/workflows/lint_test_sonar.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint_test_sonar.yml b/.github/workflows/lint_test_sonar.yml index 4457347..1dcac46 100644 --- a/.github/workflows/lint_test_sonar.yml +++ b/.github/workflows/lint_test_sonar.yml @@ -13,6 +13,9 @@ on: jobs: test: runs-on: ubuntu-22.04 + strategy: + matrix: + node: ['18.x', '20.x', '22.x', 23.x'] steps: - name: Checkout repository uses: actions/checkout@v4 @@ -21,7 +24,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '20.x' + node-version: ${{ matrix.node }} - name: Install dependencies run: npm ci - name: Run Build From 56a7825ca6c5dc89300522a0dd1f24b0a6d2567f Mon Sep 17 00:00:00 2001 From: Blackfaded Date: Mon, 18 Nov 2024 09:04:10 +0100 Subject: [PATCH 2/5] chore: fix version --- .github/workflows/lint_test_sonar.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint_test_sonar.yml b/.github/workflows/lint_test_sonar.yml index 1dcac46..d034ade 100644 --- a/.github/workflows/lint_test_sonar.yml +++ b/.github/workflows/lint_test_sonar.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-22.04 strategy: matrix: - node: ['18.x', '20.x', '22.x', 23.x'] + node: ['18', '20', '22', 23'] steps: - name: Checkout repository uses: actions/checkout@v4 From e0dbad3937e92e696bb67ca140e8e12972b0d880 Mon Sep 17 00:00:00 2001 From: Blackfaded Date: Mon, 18 Nov 2024 09:07:44 +0100 Subject: [PATCH 3/5] chore: fix version --- .github/workflows/lint_test_sonar.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint_test_sonar.yml b/.github/workflows/lint_test_sonar.yml index d034ade..8f41605 100644 --- a/.github/workflows/lint_test_sonar.yml +++ b/.github/workflows/lint_test_sonar.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-22.04 strategy: matrix: - node: ['18', '20', '22', 23'] + node: [18, 20, 22, 23] steps: - name: Checkout repository uses: actions/checkout@v4 From 5352fe0114d93a250a6bba933f5c2d6bc2df2d33 Mon Sep 17 00:00:00 2001 From: Blackfaded Date: Mon, 18 Nov 2024 09:19:00 +0100 Subject: [PATCH 4/5] docs: add link to npm --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 21b104e..79c2b56 100644 --- a/README.md +++ b/README.md @@ -35,6 +35,8 @@ Welcome to the Node SDK for the PAYONE Commerce Platform! This repository contai ## Installation +[View in NPM](https://www.npmjs.com/package/pcp-server-nodejs-sdk) + ```sh # npm npm i pcp-server-nodejs-sdk From 12a380f2515d23066f1d47ea2bd756a502d52fdd Mon Sep 17 00:00:00 2001 From: Blackfaded Date: Mon, 18 Nov 2024 09:26:09 +0100 Subject: [PATCH 5/5] build: update workflow to run sonar once --- .github/workflows/lint_test_sonar.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.github/workflows/lint_test_sonar.yml b/.github/workflows/lint_test_sonar.yml index 8f41605..7ddc333 100644 --- a/.github/workflows/lint_test_sonar.yml +++ b/.github/workflows/lint_test_sonar.yml @@ -34,6 +34,23 @@ jobs: - name: Run Format Check run: npm run format:check - name: Run Tests + run: npm run test + + sonar: + needs: [test] + runs-on: ubuntu-22.04 + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 22 + - name: Install dependencies + run: npm ci + - name: Run Tests with coverage run: npm run test:coverage - name: Run SonarCloud Scan uses: SonarSource/sonarcloud-github-action@master