Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SBML math parsing #283

Open
dweindl opened this issue Jun 27, 2024 · 0 comments
Open

Fix SBML math parsing #283

dweindl opened this issue Jun 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dweindl
Copy link
Member

dweindl commented Jun 27, 2024

petab.models.sbml_model.sympify_sbml currently uses sympy.sympify for evaluating SBML L3 formulas. Operator precedence is different between sympy and SBML L3 formulas. This can lead to hard-to-find issues. Use a proper parser, e.g. https://github.com/dweindl/sbmlmath/.
@dweindl dweindl added the bug Something isn't working label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dweindl