Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor priors #311

Open
dweindl opened this issue Oct 15, 2024 · 0 comments
Open

Refactor priors #311

dweindl opened this issue Oct 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dweindl
Copy link
Member

dweindl commented Oct 15, 2024

It would be more convenient to introduce some class Prior for dealing with parameter priors than the current tuples. Those instances should also make it easy to evaluate the prior.

EDIT: Rather a class Distribution. Refactoring sample_from_prior will be a good starting point.

@dweindl dweindl added the enhancement New feature or request label Oct 15, 2024
@dweindl dweindl self-assigned this Oct 16, 2024
@dweindl dweindl mentioned this issue Dec 4, 2024
dweindl added a commit that referenced this issue Dec 11, 2024
Introduces `Prior` and `Distribution` classes for handling PEtab-specific prior distributions, and (PEtab-version-invariant) univariate probability distributions. Supports sampling from them, and evaluating negative log-priors (#312). Later on, this can be extended to noise models for measurements and computing loglikelihoods.
This also adds a notebook demonstrating the various prior options which are a common source confusion.

Closes #311.

:eyes: notebook: https://petab--329.org.readthedocs.build/projects/libpetab-python/en/329/example/distributions.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant