-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: version check #349
Comments
Here it says we use SemVer: https://petab.readthedocs.io/en/latest/development.html#versioning-of-the-petab-format Here it says integer: https://petab.readthedocs.io/en/latest/v1/documentation_data_format.html#yaml-file-for-grouping-files Needs to be clarified. I wouldn't see a problem with implicit zeros for minor/patch. |
Here it says string/pep440 https://petab.readthedocs.io/en/latest/v2/documentation_data_format.html#yaml-file-for-grouping-files which I thought implies implicit zeros with minor/patch, but that‘s also not super evident. |
True. That needs to be simplified. I think we want to drop the epoch there, and keep any PEP references out of it. I will fix the initial issue. |
Add function for parsing version numbers. Update checks. Fixes PEtab-dev#349.
Add function for parsing version numbers. Update checks. Fixes #349.
pteab.v2.Problem.from_yaml
will only accept "2.0.0" as version string, even though it sounds like "2" would also be valid according to spec.see
libpetab-python/petab/v2/problem.py
Line 139 in 99373c4
The text was updated successfully, but these errors were encountered: