Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Test for Model Training and Energy Estimation #17

Open
davidfitzek opened this issue Oct 24, 2023 · 0 comments
Open

Integration Test for Model Training and Energy Estimation #17

davidfitzek opened this issue Oct 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@davidfitzek
Copy link
Collaborator

Description

As a part of improving test coverage and ensuring the correctness of the training process, adding an integration test that trains a small model on a dataset and verifies the energy estimation using the get_rydberg_energy function would be useful.

Acceptance Criteria

  1. Data Preparation:

    • Use the dataset located at src/rydberggpt/tests/dataset_test/.
  2. Model Training:

    • Train a small model on the specified dataset for a predefined number of steps (e.g., 100 steps).
    • Ensure the training process completes without errors.
  3. Energy Estimation:

    • Use the trained model to estimate the energy of the system using the RydbergDecoderWavefunction.get_rydberg_energy function. We can estimate the energy for a configuration that is present in the dataset.
    • Validate the estimated energy against the true energy values based on the data.

Additional Context

This test will serve as a crucial validation check for future changes, ensuring that the training process and energy estimation are functioning as expected.

Implementation Suggestions

  • It may be beneficial to create a simplified model architecture for this test to reduce the execution time.
  • The test could be structured as a new pytest function or module within the existing testing framework.
  • It may be worth considering setting a random seed to ensure reproducibility between test runs.

Questions

  1. What should be the acceptable margin of error between the estimated and true energy values?
  2. Are there any specific logging or reporting requirements for this test?
@davidfitzek davidfitzek added the enhancement New feature or request label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant