-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limiting #57
Comments
👍 |
|
+1; CloudFront returning 504's after the first ~50 requests. Workaround is to enable caching and refresh a few times; validating 50 at a time. |
#92 is related |
To add to this, it would be ideal if the extension could back off upon receiving a 429 error in particular. So, if
IMO, this should be the default behavior. A |
It would be extremely helpful if this tool included rate limiting. We've used this a few times but without rate limiting it's almost useless to us. Most of our web properties are managed through Akamai, and their application firewall will block IP addresses if it detects a high rate of errors. When using Check My Links against a page that has problems with its links it can quickly trigger the application firewall and block our entire office as a result.
The following rate limit options would be hugely useful to us:
Using the above options you could set up a scenario along these lines:
These sorts of options would make this plug-in infinitely more valuable to people who use it in environments where there are application firewalls that may rate-limit based on the amount of traffic seen from a given client, on the amount of errors caused by a client, etc. Rate limiting in application firewalls typically involves rules along the lines of "if you see 10 errors in the span of 5 seconds then block the offending IP for 30 minutes", so the ability to rate limit would let you ensure you never trigger these sorts of rules.
The text was updated successfully, but these errors were encountered: