Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics captured for processing time, critical time , message failed and message succeded are incorrect. #174

Open
andreasohlund opened this issue Feb 20, 2021 · 3 comments
Open

Metrics captured for processing time, critical time , message failed and message succeded are incorrect. #174

andreasohlund opened this issue Feb 20, 2021 · 3 comments
Labels
bug Triaged

Comments

@andreasohlund
Copy link
Member

andreasohlund commented Feb 20, 2021 •
edited
Loading

Since we trigger on OnPipelineCompleted metrics the time it takes the transport to push outgoing messages into the queueing system and acknowledge the message. This means that the metrics can be significantly skewed. We also trigger the counters for message failed and message succeded in the same event so they happen to soon as well in addition to potentially be incorrect should something fail during recoverability or when the transport completes the transport transactions.
@andreasohlund andreasohlund mentioned this issue Feb 20, 2021
Open
@andreasohlund
Copy link
Member Author

Related to Particular/NServiceBus#3565 which is similar since it results on the headers on the audit message being wrong

@andreasohlund andreasohlund mentioned this issue Feb 20, 2021
Merged
@andreasohlund
Copy link
Member Author

Will likely be fixes as we complete Particular/NServiceBus#5936 and update downstreams

@andreasohlund andreasohlund mentioned this issue Feb 26, 2021
Closed
@andreasohlund andreasohlund changed the title Metrics captured for processing time and critical time doesn't include time spend completing the message Metrics captured for processing time, critical time , message failed and message succeded are incorrect. Feb 26, 2021
@adamralph adamralph mentioned this issue Mar 5, 2021
Closed
@DavidBoike
Copy link
Member

That change was reverted for NServiceBus 8.

Particular/NServiceBus#5959 is a spike to show how this bug may be fixed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Triaged
Projects
None yet
Milestone
No milestone
2 participants
@andreasohlund @DavidBoike