Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When SqlServer.DisableDelayedDelivery is set transport still returns DoNotDeliverBefore and DelayDeliveryWith constraints to core #722

Open
ramonsmits opened this issue Nov 17, 2020 · 0 comments

Comments

@ramonsmits
Copy link
Member

ramonsmits commented Nov 17, 2020

When SqlServer.DisableDelayedDelivery is set transport still returns DoNotDeliverBefore and DelayDeliveryWith constraints to core. The setting doesn't really disable delayed delivery, its behavior is: "dont check for timeouts, and don't create the timeout queue".

Other transports that actually have a configuration API to disable delayed delivery will not return these delivery constraints. Core actively uses these to that when users invoke saga request timeout or delayed delivery options to throw an exception indicating that the transport does not support delayed delivery.

This settings exists only for ServiceControl but as other transports have similar config API's I think it would wise to:

  1. Make this key part of the public API
  2. Rename this key with a name that doesn't state "disable" but UndocumentedServiceControlOptimilization or IgnoreDelayedDeliveryInfra or something else or ensure that it actually disables delayed delivery meaning not returning DoNotDeliverBefore and DelayDeliveryWith capabilities to core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant