Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove casting functions between the adjacent types #236

Closed
PaulRBerg opened this issue Jun 27, 2024 · 0 comments · Fixed by #237
Closed

Remove casting functions between the adjacent types #236

PaulRBerg opened this issue Jun 27, 2024 · 0 comments · Fixed by #237
Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: refactor Change that neither fixes a bug nor adds a feature. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Owner

While reviewing #212, I realized that maintaining casting functions between the adjacent types and all other types is:

  1. Overkill and not helpful; I don't think users need this.
  2. Increasing maintenance costs in an exponential way; the more adjacent types there are, the crazier the interdependencies become, and the more 'plumbing' code has to be written.

Thus, the task is to remove all casting functions between the adjacent types and all other types, e.g. between SD1x18 and UD2x18.

Note that the casting between (i) adjacent types and SD59x18 and UD60x18 and (ii) between SD59x18 and UD60x18 should continue to be maintained given that these are the core types implementing the mathematical logic.

@PaulRBerg PaulRBerg added type: refactor Change that neither fixes a bug nor adds a feature. priority: 1 This is important. It should be dealt with shortly. effort: medium Default level of effort. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: refactor Change that neither fixes a bug nor adds a feature. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant