From dca1b408f270abf5a970f1b4e16328b73d0f5364 Mon Sep 17 00:00:00 2001
From: Doug Wegscheid <dwegscheid@sbcglobal.net>
Date: Tue, 24 Jan 2023 15:10:37 -0500
Subject: [PATCH 1/7] Allow specifying NT server address by ip.

Still need to fix the UI!
---
 .../common/configuration/NetworkConfig.java   |  7 ++++---
 .../networktables/NetworkTablesManager.java   | 21 ++++++++++++++-----
 .../common/networking/NetworkManager.java     |  2 +-
 3 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java b/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
index cae9c92aa8..d6e6706257 100644
--- a/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
+++ b/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
@@ -17,6 +17,7 @@
 
 package org.photonvision.common.configuration;
 
+import com.fasterxml.jackson.annotation.JsonAlias;
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonGetter;
 import com.fasterxml.jackson.annotation.JsonIgnore;
@@ -30,7 +31,7 @@
 import org.photonvision.common.util.file.JacksonUtils;
 
 public class NetworkConfig {
-    public int teamNumber = 0;
+    public String ntServerAddress = "0";
     public NetworkMode connectionType = NetworkMode.DHCP;
     public String staticIp = "";
     public String hostname = "photonvision";
@@ -54,7 +55,7 @@ public NetworkConfig() {
 
     @JsonCreator
     public NetworkConfig(
-            @JsonProperty("teamNumber") int teamNumber,
+            @JsonProperty("ntServerAddress") @JsonAlias({"ntServerAddress", "teamNumber"}) String ntServerAddress,
             @JsonProperty("connectionType") NetworkMode connectionType,
             @JsonProperty("staticIp") String staticIp,
             @JsonProperty("hostname") String hostname,
@@ -64,7 +65,7 @@ public NetworkConfig(
             @JsonProperty("physicalInterface") String physicalInterface,
             @JsonProperty("setStaticCommand") String setStaticCommand,
             @JsonProperty("setDHCPcommand") String setDHCPcommand) {
-        this.teamNumber = teamNumber;
+        this.ntServerAddress = ntServerAddress;
         this.connectionType = connectionType;
         this.staticIp = staticIp;
         this.hostname = hostname;
diff --git a/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java b/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
index fb31adc96e..41efbfb6ff 100644
--- a/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
+++ b/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
@@ -66,7 +66,12 @@ public void accept(NetworkTableEvent event) {
                 getInstance().broadcastConnectedStatus();
             } else if (event.logMessage.message.contains("connected")
                     && System.currentTimeMillis() - lastConnectMessageMillis > 125) {
-                logger.info("NT Connected!");
+                String connectionDescription = "(unknown)";
+                var connections = getInstance().ntInstance.getConnections();
+                if (connections.length > 0) {
+                    connectionDescription = connections[0].remote_ip + ":" + connections[0].remote_port;
+                }
+                logger.info("NT Connected to " + connectionDescription + "!");
                 hasReportedConnectionFailure = false;
                 lastConnectMessageMillis = System.currentTimeMillis();
                 ScriptManager.queueEvent(ScriptEventType.kNTConnected);
@@ -107,16 +112,22 @@ public void setConfig(NetworkConfig config) {
         if (config.runNTServer) {
             setServerMode();
         } else {
-            setClientMode(config.teamNumber);
+            setClientMode(config.ntServerAddress);
         }
         broadcastVersion();
     }
 
-    private void setClientMode(int teamNumber) {
-        if (!isRetryingConnection) logger.info("Starting NT Client");
+    private void setClientMode(String ntServerAddress) {
         ntInstance.stopServer();
         ntInstance.startClient4("photonvision");
-        ntInstance.setServerTeam(teamNumber);
+        try {
+            Integer t = Integer.parseInt(ntServerAddress);
+            if (!isRetryingConnection) logger.info("Starting NT Client, server team is " + t);
+            ntInstance.setServerTeam(t);
+        } catch (NumberFormatException e) {
+            if (!isRetryingConnection) logger.info("Starting NT Client, server IP is \"" + ntServerAddress + "\"");
+            ntInstance.setServer(ntServerAddress);
+        }
         ntInstance.startDSClient();
         broadcastVersion();
     }
diff --git a/photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java b/photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
index 505dc33a90..0a76b093c6 100644
--- a/photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
+++ b/photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
@@ -46,7 +46,7 @@ public void initialize(boolean shouldManage) {
         }
 
         var config = ConfigManager.getInstance().getConfig().getNetworkConfig();
-        logger.info("Setting " + config.connectionType + " with team team " + config.teamNumber);
+        logger.info("Setting " + config.connectionType + " with team " + config.ntServerAddress);
         if (Platform.isLinux()) {
             if (!Platform.isRoot()) {
                 logger.error("Cannot manage hostname without root!");

From 4f084f9fe11587693b9b0138ca824e7dbf39c082 Mon Sep 17 00:00:00 2001
From: Doug Wegscheid <dwegscheid@sbcglobal.net>
Date: Tue, 24 Jan 2023 23:50:09 -0500
Subject: [PATCH 2/7] Get basic UI working for arbitrary NT addresses.

Need to get validation working!
---
 photon-client/src/App.vue                     |  4 ++--
 photon-client/src/store/index.js              |  2 +-
 photon-client/src/views/PipelineView.vue      |  2 +-
 .../src/views/SettingsViews/Networking.vue    | 22 +++++++++----------
 photon-server/netTest.json                    |  2 +-
 5 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/photon-client/src/App.vue b/photon-client/src/App.vue
index 99a9416fee..c0cf83c2a0 100644
--- a/photon-client/src/App.vue
+++ b/photon-client/src/App.vue
@@ -81,7 +81,7 @@
               </v-list-item-title>
               <router-link v-if="!$store.state.settings.networkSettings.runNTServer" to="settings" class="accent--text"
                 @click="switchToSettingsTab">
-                Team number is {{ $store.state.settings.networkSettings.teamNumber }}
+                NT server is {{ $store.state.settings.networkSettings.ntServerAddress }}
               </router-link>
             </v-list-item-content>
           </v-list-item>
@@ -151,7 +151,7 @@ export default {
   computed: {
     needsTeamNumberSet: {
       get() {
-        return this.$store.state.settings.networkSettings.teamNumber < 1
+        return this.$store.state.settings.networkSettings.ntServerAddress == ""
           && this.teamNumberDialog && this.$store.state.backendConnected
           && !this.$route.name.toLowerCase().includes("settings");
       }
diff --git a/photon-client/src/store/index.js b/photon-client/src/store/index.js
index b0e4755695..52e29e524d 100644
--- a/photon-client/src/store/index.js
+++ b/photon-client/src/store/index.js
@@ -135,7 +135,7 @@ export default new Vuex.Store({
                 hardwarePlatform: "Unknown",
             },
             networkSettings: {
-                teamNumber: 0,
+                ntServerAddress: "",
 
                 supported: true,
                 // Below options are only configurable if supported is true
diff --git a/photon-client/src/views/PipelineView.vue b/photon-client/src/views/PipelineView.vue
index a6f7ef4891..910642a1f1 100644
--- a/photon-client/src/views/PipelineView.vue
+++ b/photon-client/src/views/PipelineView.vue
@@ -475,7 +475,7 @@ export default {
     },
     showNTWarning: {
       get() {
-        return (!this.$store.state.ntConnectionInfo.connected || this.$store.state.settings.networkSettings.runNTServer) && this.$store.state.settings.networkSettings.teamNumber > 0 && this.$store.state.backendConnected && !this.hideNTWarning;
+        return (!this.$store.state.ntConnectionInfo.connected || this.$store.state.settings.networkSettings.runNTServer) && this.$store.state.settings.networkSettings.ntServerAddress != "" && this.$store.state.backendConnected && !this.hideNTWarning;
       }
     },
   },
diff --git a/photon-client/src/views/SettingsViews/Networking.vue b/photon-client/src/views/SettingsViews/Networking.vue
index 38ed868fb4..d03c2b61bf 100644
--- a/photon-client/src/views/SettingsViews/Networking.vue
+++ b/photon-client/src/views/SettingsViews/Networking.vue
@@ -4,21 +4,21 @@
       ref="form"
       v-model="valid"
     >
-      <CVnumberinput
-        v-model="teamNumber"
+      <CVinput
+        v-model="ntServerAddress"
+        :input-cols="inputCols"
         :disabled="settings.runNTServer"
         name="Team Number"
-        :rules="[v => (v > 0) || 'Team number must be greater than zero', v => (v < 10000) || 'Team number must have fewer than five digits']"
-        class="mb-4"
-        :label-cols="$vuetify.breakpoint.mdAndUp ? undefined : 5"
+        tooltip="enter the team number or the IP address of the robot NetworkTables server"
+        :rules="[v => (v != '') || 'Team Number must be non blank']"
       />
       <v-banner
-        v-show="(teamNumber < 1 || teamNumber > 10000) && !runNTServer"
+        v-show="(ntServerAddress == '') && !runNTServer"
         rounded
         color="red"
         text-color="white"
       >
-        Team number is unset or invalid. NetworkTables will not be able to connect.
+        "Team Number or NetworkTablesIP" is unset or invalid. NetworkTables will not be able to connect.
       </v-banner>
       <CVradio
         v-show="$store.state.settings.networkSettings.shouldManage"
@@ -165,7 +165,6 @@
 </template>
 
 <script>
-import CVnumberinput from '../../components/common/cv-number-input'
 import CVradio from '../../components/common/cv-radio'
 import CVinput from '../../components/common/cv-input'
 import CVSwitch from "@/components/common/cv-switch";
@@ -179,7 +178,6 @@ export default {
     name: 'Networking',
     components: {
         CVSwitch,
-        CVnumberinput,
         CVradio,
         CVinput
     },
@@ -205,12 +203,12 @@ export default {
         settings() {
             return this.$store.state.settings.networkSettings;
         },
-        teamNumber: {
+        ntServerAddress: {
             get() {
-                return this.settings.teamNumber
+                return this.settings.ntServerAddress
             },
             set(value) {
-                this.$store.commit('mutateNetworkSettings', {['teamNumber']: value || 0});
+                this.$store.commit('mutateNetworkSettings', {['ntServerAddress']: value || ""});
            }
         },
         runNTServer: {
diff --git a/photon-server/netTest.json b/photon-server/netTest.json
index dcfbb1247e..56a12f2822 100644
--- a/photon-server/netTest.json
+++ b/photon-server/netTest.json
@@ -1 +1 @@
-{"teamNumber":0,"connectionType":"DHCP","staticIp":"","hostname":"photonvision","runNTServer":false,"shouldManage":false}
+{"ntServerAddress":"","connectionType":"DHCP","staticIp":"","hostname":"photonvision","runNTServer":false,"shouldManage":false}

From a16cbab6bdf6edbb92cc0e32c5aa96152887db0e Mon Sep 17 00:00:00 2001
From: Doug Wegscheid <dwegscheid@sbcglobal.net>
Date: Wed, 25 Jan 2023 01:08:41 -0500
Subject: [PATCH 3/7] Validation of "team number" is working.

---
 .../src/views/SettingsViews/Networking.vue     | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/photon-client/src/views/SettingsViews/Networking.vue b/photon-client/src/views/SettingsViews/Networking.vue
index d03c2b61bf..0b49b42a9d 100644
--- a/photon-client/src/views/SettingsViews/Networking.vue
+++ b/photon-client/src/views/SettingsViews/Networking.vue
@@ -10,15 +10,15 @@
         :disabled="settings.runNTServer"
         name="Team Number"
         tooltip="enter the team number or the IP address of the robot NetworkTables server"
-        :rules="[v => (v != '') || 'Team Number must be non blank']"
+        :rules="[v => isValidTeamNumber(v) || 'Team Number must be non blank and a team number, IP address, or hostname']"
       />
       <v-banner
-        v-show="(ntServerAddress == '') && !runNTServer"
+        v-show="!isValidTeamNumber(ntServerAddress) && !runNTServer"
         rounded
         color="red"
         text-color="white"
       >
-        "Team Number or NetworkTablesIP" is unset or invalid. NetworkTables will not be able to connect.
+        Team Number unset or invalid. NetworkTables will not be able to connect.
       </v-banner>
       <CVradio
         v-show="$store.state.settings.networkSettings.shouldManage"
@@ -173,6 +173,8 @@ import CVSwitch from "@/components/common/cv-switch";
 const ipv4Regex = /^((25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])\.){3,3}(25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])$/;
 // https://stackoverflow.com/a/18494710
 const hostnameRegex = /^([a-zA-Z0-9]+(-[a-zA-Z0-9]+)*)+(\.([a-zA-Z0-9]+(-[a-zA-Z0-9]+)*))*$/;
+const teamNumberRegex = /^[1-9][0-9]{0,3}$/;
+const badTeamNumberRegex = /^[0-9]{5,}$/;
 
 export default {
     name: 'Networking',
@@ -245,6 +247,16 @@ export default {
         },
     },
     methods: {
+        isValidTeamNumber(v) {
+            if (teamNumberRegex.test(v)) return true;
+            if (ipv4Regex.test(v)) return true;
+            // need to check these before the hostname. "0" and "99999" are valid hostnames,
+            // but we don't want to allow then
+            if (v == '0') return false;
+            if (badTeamNumberRegex.test(v)) return false;
+            if (hostnameRegex.test(v)) return true;
+            return false;
+        },
         isIPv4(v) {
             return ipv4Regex.test(v);
         },

From 7bf11001c5746edd19ffe1331975e7381e317c34 Mon Sep 17 00:00:00 2001
From: Doug Wegscheid <dwegscheid@sbcglobal.net>
Date: Wed, 25 Jan 2023 01:12:59 -0500
Subject: [PATCH 4/7] Don't show hostname in settings if we aren't managing it.

---
 photon-client/src/views/SettingsViews/Networking.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/photon-client/src/views/SettingsViews/Networking.vue b/photon-client/src/views/SettingsViews/Networking.vue
index 0b49b42a9d..507dd9bf79 100644
--- a/photon-client/src/views/SettingsViews/Networking.vue
+++ b/photon-client/src/views/SettingsViews/Networking.vue
@@ -36,6 +36,7 @@
         name="IP"
       />
       <CVinput
+        v-show="$store.state.settings.networkSettings.shouldManage"
         v-model="hostname"
         :input-cols="inputCols"
         :rules="[v => isHostname(v) || 'Invalid hostname']"

From 1276d58aa023e43b20eed0f3f2dd785c27e958e9 Mon Sep 17 00:00:00 2001
From: Doug Wegscheid <dwegscheid@sbcglobal.net>
Date: Wed, 25 Jan 2023 19:49:04 -0500
Subject: [PATCH 5/7] did gradlew spotlessApply

---
 .../org/photonvision/common/configuration/NetworkConfig.java   | 3 ++-
 .../common/dataflow/networktables/NetworkTablesManager.java    | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java b/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
index d6e6706257..0ff570abc0 100644
--- a/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
+++ b/photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
@@ -55,7 +55,8 @@ public NetworkConfig() {
 
     @JsonCreator
     public NetworkConfig(
-            @JsonProperty("ntServerAddress") @JsonAlias({"ntServerAddress", "teamNumber"}) String ntServerAddress,
+            @JsonProperty("ntServerAddress") @JsonAlias({"ntServerAddress", "teamNumber"})
+                    String ntServerAddress,
             @JsonProperty("connectionType") NetworkMode connectionType,
             @JsonProperty("staticIp") String staticIp,
             @JsonProperty("hostname") String hostname,
diff --git a/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java b/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
index 41efbfb6ff..2f17cc1a95 100644
--- a/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
+++ b/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
@@ -125,7 +125,8 @@ private void setClientMode(String ntServerAddress) {
             if (!isRetryingConnection) logger.info("Starting NT Client, server team is " + t);
             ntInstance.setServerTeam(t);
         } catch (NumberFormatException e) {
-            if (!isRetryingConnection) logger.info("Starting NT Client, server IP is \"" + ntServerAddress + "\"");
+            if (!isRetryingConnection)
+                logger.info("Starting NT Client, server IP is \"" + ntServerAddress + "\"");
             ntInstance.setServer(ntServerAddress);
         }
         ntInstance.startDSClient();

From 974cf8a9ef2338497696732078f575cc08aa0e99 Mon Sep 17 00:00:00 2001
From: Doug Wegscheid <dwegscheid@sbcglobal.net>
Date: Fri, 27 Jan 2023 13:40:45 -0500
Subject: [PATCH 6/7] Add unit test.

---
 .../common/configuration/NetworkConfigTest.java  | 16 ++++++++++++++++
 .../network-new-team-number/networkSettings.json |  3 +++
 .../network-old-team-number/networkSettings.json |  3 +++
 3 files changed, 22 insertions(+)
 create mode 100644 test-resources/network-new-team-number/networkSettings.json
 create mode 100644 test-resources/network-old-team-number/networkSettings.json

diff --git a/photon-core/src/test/java/org/photonvision/common/configuration/NetworkConfigTest.java b/photon-core/src/test/java/org/photonvision/common/configuration/NetworkConfigTest.java
index 181598bc30..701ba3cf80 100644
--- a/photon-core/src/test/java/org/photonvision/common/configuration/NetworkConfigTest.java
+++ b/photon-core/src/test/java/org/photonvision/common/configuration/NetworkConfigTest.java
@@ -33,4 +33,20 @@ public void testSerialization() throws IOException {
         Assertions.assertDoesNotThrow(() -> mapper.readValue(path.toFile(), NetworkConfig.class));
         new File("netTest.json").delete();
     }
+
+    @Test
+    public void testDeserializeTeamNumberOrNtServerAddress() {
+        {
+            ConfigManager configMgr =
+                    new ConfigManager(Path.of("test-resources/network-old-team-number"));
+            configMgr.load();
+            Assertions.assertEquals("9999", configMgr.getConfig().getNetworkConfig().ntServerAddress);
+        }
+        {
+            ConfigManager configMgr =
+                    new ConfigManager(Path.of("test-resources/network-new-team-number"));
+            configMgr.load();
+            Assertions.assertEquals("9999", configMgr.getConfig().getNetworkConfig().ntServerAddress);
+        }
+    }
 }
diff --git a/test-resources/network-new-team-number/networkSettings.json b/test-resources/network-new-team-number/networkSettings.json
new file mode 100644
index 0000000000..09b3fffe60
--- /dev/null
+++ b/test-resources/network-new-team-number/networkSettings.json
@@ -0,0 +1,3 @@
+{
+  "ntServerAddress" : "9999"
+}
\ No newline at end of file
diff --git a/test-resources/network-old-team-number/networkSettings.json b/test-resources/network-old-team-number/networkSettings.json
new file mode 100644
index 0000000000..51d9badf74
--- /dev/null
+++ b/test-resources/network-old-team-number/networkSettings.json
@@ -0,0 +1,3 @@
+{
+  "teamNumber" : 9999
+}
\ No newline at end of file

From 1dbda031e123064b035eee22c2c05ae8f60446b3 Mon Sep 17 00:00:00 2001
From: Doug Wegscheid <dwegscheid@sbcglobal.net>
Date: Thu, 11 May 2023 09:14:40 -0400
Subject: [PATCH 7/7] wpiformat

---
 test-resources/network-new-team-number/networkSettings.json | 2 +-
 test-resources/network-old-team-number/networkSettings.json | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test-resources/network-new-team-number/networkSettings.json b/test-resources/network-new-team-number/networkSettings.json
index 09b3fffe60..cd7ec6b0bf 100644
--- a/test-resources/network-new-team-number/networkSettings.json
+++ b/test-resources/network-new-team-number/networkSettings.json
@@ -1,3 +1,3 @@
 {
   "ntServerAddress" : "9999"
-}
\ No newline at end of file
+}
diff --git a/test-resources/network-old-team-number/networkSettings.json b/test-resources/network-old-team-number/networkSettings.json
index 51d9badf74..d4165c4ba3 100644
--- a/test-resources/network-old-team-number/networkSettings.json
+++ b/test-resources/network-old-team-number/networkSettings.json
@@ -1,3 +1,3 @@
 {
   "teamNumber" : 9999
-}
\ No newline at end of file
+}