Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Endpoint may have changed #3

Open
starfury66 opened this issue Jan 29, 2024 · 4 comments
Open

API Endpoint may have changed #3

starfury66 opened this issue Jan 29, 2024 · 4 comments

Comments

@starfury66
Copy link

When trying to use ultimate-guitar-scraper with the get_all option I get an 404 error.

It seems the API Endpoint for /list/myTab has changed.

@starfury66
Copy link
Author

Aah, I've made the mistake by myself. My tabs are stored as personal tab, so I had to use the endpoint /list/personal and not /list/myTab.

@Pilfer
Copy link
Owner

Pilfer commented Jan 31, 2024

I'm glad you were able to figure it out! I haven't played with any of the authenticated routes at all, so if you'd like to document whatever extra calls you're making and issue a PR, I'd happily accept it 😃

@starfury66
Copy link
Author

I'd like to make a Pull Request, but I build my own code in Python based on your Go code.

To access my "Personal Tabs" I added 'PERSONAL = "/list/personal"' to the API.AppPaths, done the login like described in your code, got a token, and got the list of my personal tabs by sending a request to the Endpoint with the token attached.

In the JSON object returned from the API there is 'tab_access_type': 'personal' for every tab and I got the corresponding tab by using the procedure like in your code, but changing 'access_type=private' in the API request to 'access_type=personal'.

En Voila, you get your personal tabs in a huge JSON object.

I've done only a quick and dirty hack, because I want to switch my tabs from UG to SongbookPro (I don't like the way UG is developing - much more ads and the Android App is getting worse and worse) and don't intend to use the code later.

If you're interested, I can send you the Python source.

@Pilfer
Copy link
Owner

Pilfer commented Feb 1, 2024

Thanks for the rough docs!

I'm so glad that you were able to utilize this codebase to do something so useful - that's exactly why I decided to publish it. I agree fully re: UG's user experience.

If you ever want to clean up your Python source and release it, I'll link to it in the README. Go isn't everyone's favorite language, so it may be a bit easier for people to interface with the API if they have clients in other languages available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants