Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default assignment to sort_sublattice_intensities #75

Open
michaelhennessyjr opened this issue May 23, 2022 · 1 comment
Open

Add default assignment to sort_sublattice_intensities #75

michaelhennessyjr opened this issue May 23, 2022 · 1 comment
Assignees

Comments

@michaelhennessyjr
Copy link
Collaborator

If sort_sublattice_intensities fails to assign an elemental configuration to a given site, it either assigns the highest intensity configuration or the most common sublattice element (found using get_most_common_sublattice_element). This works well, except for when the most common sublattice element is blank (''), as the function will find all the blanks and replace them with blanks.

It shouldn't be the case that the most common sublattice element is blank, but it might be useful to include a parameter in the function for a standard element to use as a default assignment for cases like this.

@michaelhennessyjr michaelhennessyjr self-assigned this May 23, 2022
@PinkShnack
Copy link
Owner

Hey Mike, did you ever implement this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants