Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of Contents link in localized page incorrectly links to English version #339

Open
EatChangmyeong opened this issue Jan 8, 2022 · 2 comments

Comments

@EatChangmyeong
Copy link
Contributor

In any localized version of the book, clicking any "table of contents" link next to chapter names links to /#toc instead of [language code]/index.html#toc. Manually browsing to /[language code]/index.html#toc works fine.

"목차" (table of contents) link in Korean version, linking to https://pomax.github.io/bezierinfo/#toc

Actually I would be able to examine the code to fix the bug myself, but for now I'd like to focus on translation work.

@Pomax
Copy link
Owner

Pomax commented Jan 8, 2022

In fact, there should not be any / at all, it should just link to #toc. Good find.

@Pomax
Copy link
Owner

Pomax commented Jan 9, 2022

Ah, I see. This is caused by the <base> element, which is necessary for correctly resolving images etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants