Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float32 -> integer sample conversions (e.g. Float32_To_Int32()) needs to be documented and tested #977

Open
philburk opened this issue Oct 28, 2024 · 1 comment

Comments

@philburk
Copy link
Collaborator

We should document the wrapping behavior for the range +1.0 to -1.0.
And we should added tests to guarantee it on all platforms.
Wrapping would be very audible and a regression.

We are not currently documenting the linearity around zero.

@philburk philburk changed the title Float32_To_Int32 needs to be documented and tested Float32_To_Int32() needs to be documented and tested Oct 28, 2024
@RossBencina
Copy link
Collaborator

The purpose of these tests is to ensure that any changes to the conversion functions (e.g. as discussed in #835) do not exhibit undesirable regressions. The worst type of regression would be if floating point values that currently convert without gross artifacts (e.g. wrap-around) suddenly start distorting.

@RossBencina RossBencina changed the title Float32_To_Int32() needs to be documented and tested Float32 -> integer sample conversions (e.g. Float32_To_Int32()) needs to be documented and tested Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants