-
Notifications
You must be signed in to change notification settings - Fork 205
xWSMan module available but needs community assistance #215
Comments
We actually have a new module submission for WSManDsc open right now. Just waiting on review: |
Nice. It also looks like there are some features that are unique across the two, so perhaps they could be compared and some capabilities could be merged. |
Yes, that would be great! |
@mgreenegit , @mbreakey3 - cool! I'll definitely help get that in line. Looks like the two resource modules will compliment each other really well. This might be an opportunity to define a "merge" process for merging files from two repos that don't share a common ancestor. @mbreakey3 - have you guys ever done this and if so is there an existing process/method we could use? Or should this just be a case of "Copy/Paste" 😁 |
@PlagueHO Try out this one, and see if it needs improving. Might not work since it expects the same source for the rebase. Don't know if it possible to rebase/merge over different repos. |
@PlagueHO, @johlju - Yeah, we don't have a defined 'merge' process for this situation yet. The easiest would be to get one merged in and then have the other contributor create a PR to add/update their own changes. However, since we've been a bit behind on reviewing new module submissions, if any of you want to work on merging the two together beforehand, that might make the process faster. That would require you to work in each other's repos though (whichever one you choose to be the 'base' module). |
@mbreakey3 - as the WSManDsc should be nearing being moved over (2 out of 3 reviews complete I think from memory) I'm not sure I'd want to muddy things up by adding to it till after it has been merged. Also, given that the repo is in that special review state (reviewBase/reviewTarget branches) then I'm not even sure of the pattern that would be adopted here. It could end up messing up the existing review - and I'm sure none of want to go through it again 😁 |
@PlagueHO would you be okay if we move this issue to a new issue in the repo https://github.com/PlagueHO/WSManDsc? Maybe someone can work on it there instead? |
Fine with me...@mgreenegit? I'd definitely like to incorporate @robwi's resource into mine as it provides some very complimentary features. Just needs HQRM, tests & examples etc. But nothing too major. |
This issue was moved to https://github.com/PlagueHO/WSManDsc/issues/18 since it has a higher chance that it can get help there. Closing this issue at this time. |
A module for WSMan is available but needs assistance from the community. Review, tests, and docs.
https://github.com/robwi/xWSMan
HELP WANTED
The text was updated successfully, but these errors were encountered: