From 989dd653209bd55cf9df278a314a6c61bc05d088 Mon Sep 17 00:00:00 2001
From: Guillaume Lepoetre
Date: Fri, 27 Oct 2023 16:48:13 +0200
Subject: [PATCH 01/14] feat: add data-test attribute
---
.../components/accordion/src/accordion.ts | 20 ++++++++
.../components/accordion/src/accordion.vue | 15 +++++-
.../accordion/stories/accordion.stories.ts | 15 ++++++
packages/components/alert/src/alert.ts | 15 ++++++
packages/components/alert/src/alert.vue | 6 ++-
.../components/alert/stories/alert.stories.ts | 12 +++++
packages/components/badge/src/badge.ts | 5 ++
packages/components/badge/src/badge.vue | 6 ++-
.../components/badge/stories/badge.stories.ts | 5 ++
.../components/breadcrumb/src/breadcrumb.ts | 3 +-
.../components/breadcrumb/src/breadcrumb.vue | 6 ++-
.../breadcrumb/stories/breadcrumb.stories.ts | 1 +
packages/components/button/src/button.ts | 15 ++++++
packages/components/button/src/button.vue | 3 ++
.../button/stories/button.stories.ts | 15 ++++++
packages/components/checkbox/src/checkbox.ts | 10 ++++
packages/components/checkbox/src/checkbox.vue | 2 +
.../checkbox/stories/checkbox.stories.ts | 8 ++++
packages/components/icon/src/icon.ts | 5 ++
packages/components/icon/src/icon.vue | 7 ++-
.../components/icon/stories/icon.stories.ts | 4 ++
packages/components/input/src/input.ts | 10 ++++
packages/components/input/src/input.vue | 6 ++-
.../components/input/stories/input.stories.ts | 8 ++++
packages/components/label/src/label.ts | 5 ++
packages/components/label/src/label.vue | 2 +-
.../components/label/stories/label.stories.ts | 4 ++
packages/components/link/src/link.ts | 5 ++
packages/components/link/src/link.vue | 1 +
.../components/link/stories/link.stories.ts | 4 ++
.../components/menu/src/menu-item-title.ts | 8 +++-
.../components/menu/src/menu-item-title.vue | 2 +-
.../menu/stories/menu-item-title.stories.ts | 48 +++++++++++++++++++
.../components/menu/stories/menu.stories.ts | 2 +-
packages/components/modal/src/modal.ts | 25 ++++++++++
packages/components/modal/src/modal.vue | 8 +++-
.../components/modal/stories/modal.stories.ts | 25 ++++++++++
.../pagination/src/pagination-large.ts | 15 ++++++
.../pagination/src/pagination-large.vue | 4 +-
.../pagination/src/pagination-loader.ts | 5 ++
.../pagination/src/pagination-loader.vue | 1 +
.../pagination/src/pagination-medium.ts | 15 ++++++
.../pagination/src/pagination-medium.vue | 4 +-
.../pagination/src/pagination-mobile.ts | 15 ++++++
.../pagination/src/pagination-mobile.vue | 4 +-
.../pagination/src/pagination-small.ts | 15 ++++++
.../pagination/src/pagination-small.vue | 4 +-
.../components/pagination/src/pagination.ts | 15 ++++++
.../components/pagination/src/pagination.vue | 13 +++++
.../pagination/stories/pagination.stories.ts | 36 ++++++++++++++
.../progress-bar/src/progress-bar.ts | 5 ++
.../progress-bar/src/progress-bar.vue | 1 +
.../stories/progress-bar.stories.ts | 6 +++
.../src/progress-stepper-step.ts | 15 ++++++
.../src/progress-stepper-step.vue | 8 +++-
.../stories/progress-stepper-step.stories.ts | 12 +++++
packages/components/radio/src/radio.ts | 10 ++++
packages/components/radio/src/radio.vue | 8 +++-
.../components/radio/stories/radio.stories.ts | 10 ++++
.../components/select/test/select.spec.ts | 2 +-
packages/components/tooltip/src/tooltip.ts | 10 ++++
packages/components/tooltip/src/tooltip.vue | 2 +
.../tooltip/stories/tooltip.stories.ts | 8 ++++
63 files changed, 563 insertions(+), 21 deletions(-)
create mode 100644 packages/components/menu/stories/menu-item-title.stories.ts
diff --git a/packages/components/accordion/src/accordion.ts b/packages/components/accordion/src/accordion.ts
index 8c14194e..7ef6ac2f 100644
--- a/packages/components/accordion/src/accordion.ts
+++ b/packages/components/accordion/src/accordion.ts
@@ -7,21 +7,41 @@ export const accordionProps = buildProps({
type: String,
required: true,
},
+ buttonDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
title: {
type: String,
required: false,
default: undefined,
},
+ titleDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
subTitle: {
type: String,
required: false,
default: undefined,
},
+ subTitleDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
icon: {
type: String,
required: false,
default: undefined,
},
+ iconDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
disabled: {
type: Boolean,
required: false,
diff --git a/packages/components/accordion/src/accordion.vue b/packages/components/accordion/src/accordion.vue
index bebae64a..6657a4ad 100644
--- a/packages/components/accordion/src/accordion.vue
+++ b/packages/components/accordion/src/accordion.vue
@@ -11,6 +11,7 @@
:aria-controls="id"
class="puik-accordion__header"
:disabled="disabled"
+ :data-test="buttonDataTest"
@click="onClick"
>
diff --git a/packages/components/progress-stepper/stories/progress-stepper-step.stories.ts b/packages/components/progress-stepper/stories/progress-stepper-step.stories.ts
index d3fbca4a..016239f2 100644
--- a/packages/components/progress-stepper/stories/progress-stepper-step.stories.ts
+++ b/packages/components/progress-stepper/stories/progress-stepper-step.stories.ts
@@ -15,14 +15,26 @@ export default {
},
},
},
+ stepDataTest: {
+ description: 'Set the data-test of the step',
+ control: 'text',
+ },
text: {
description: 'Text of the step',
control: 'text',
},
+ textDataTest: {
+ description: 'Set the data-test of the text',
+ control: 'text',
+ },
'additional-text': {
description: 'Additional text of the step',
control: 'text',
},
+ additionalTextDataTest: {
+ description: 'Set the data-test of the additional text',
+ control: 'text',
+ },
click: {
description: 'Event emitted on click step',
control: 'none',
diff --git a/packages/components/radio/src/radio.ts b/packages/components/radio/src/radio.ts
index 5217e99c..5df5d815 100644
--- a/packages/components/radio/src/radio.ts
+++ b/packages/components/radio/src/radio.ts
@@ -8,6 +8,11 @@ export const radioProps = buildProps({
required: false,
default: undefined,
},
+ labelDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
name: {
type: String,
required: false,
@@ -28,6 +33,11 @@ export const radioProps = buildProps({
required: false,
default: false,
},
+ inputDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
} as const)
export type RadioProps = ExtractPropTypes
diff --git a/packages/components/radio/src/radio.vue b/packages/components/radio/src/radio.vue
index dba853d7..8ac404b1 100644
--- a/packages/components/radio/src/radio.vue
+++ b/packages/components/radio/src/radio.vue
@@ -10,9 +10,15 @@
class="puik-radio__input"
type="radio"
:name="name"
+ :data-test="inputDataTest"
@focus="handleFocus"
/>
-
@@ -76,10 +79,11 @@
diff --git a/packages/components/select/stories/select.stories.ts b/packages/components/select/stories/select.stories.ts
index a34b96aa..0858f2f9 100644
--- a/packages/components/select/stories/select.stories.ts
+++ b/packages/components/select/stories/select.stories.ts
@@ -109,6 +109,27 @@ export default {
category: 'Common',
},
},
+ selectDataTest: {
+ control: 'text',
+ description: 'Set the data-test attribute for the select',
+ table: {
+ category: 'Common',
+ },
+ },
+ searchInputDataTest: {
+ control: 'text',
+ description: 'Set the data-test attribute for the search input',
+ table: {
+ category: 'Searchable',
+ },
+ },
+ noResultsDataTest: {
+ control: 'text',
+ description: 'Set the data-test attribute for the no results message',
+ table: {
+ category: 'Searchable',
+ },
+ },
},
args: {
labelKey: '',
From d0ffbe74f2bccfba57d94d705db8094db7deb460 Mon Sep 17 00:00:00 2001
From: Guillaume Lepoetre
Date: Mon, 30 Oct 2023 14:29:36 +0100
Subject: [PATCH 03/14] feat: Add sidebar data-test
---
packages/components/sidebar/src/sidebar-group-item.ts | 5 +++++
packages/components/sidebar/src/sidebar-group-item.vue | 4 ++++
packages/components/sidebar/src/sidebar-item.ts | 5 +++++
packages/components/sidebar/src/sidebar-item.vue | 6 +++++-
packages/components/sidebar/src/sidebar-title.ts | 5 +++++
packages/components/sidebar/src/sidebar-title.vue | 7 ++++++-
.../sidebar/stories/sidebar-group-item.stories.ts | 4 ++++
.../components/sidebar/stories/sidebar-item.stories.ts | 4 ++++
.../components/sidebar/stories/sidebar-title.stories.ts | 4 ++++
9 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/packages/components/sidebar/src/sidebar-group-item.ts b/packages/components/sidebar/src/sidebar-group-item.ts
index dc7dc984..059a07f6 100644
--- a/packages/components/sidebar/src/sidebar-group-item.ts
+++ b/packages/components/sidebar/src/sidebar-group-item.ts
@@ -21,6 +21,11 @@ export const sidebarGroupItemProps = buildProps({
default: false,
required: false,
},
+ sidebarGroupItemDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
} as const)
export type SidebarGroupItemProps = ExtractPropTypes<
diff --git a/packages/components/sidebar/src/sidebar-group-item.vue b/packages/components/sidebar/src/sidebar-group-item.vue
index 5697b649..df2334de 100644
--- a/packages/components/sidebar/src/sidebar-group-item.vue
+++ b/packages/components/sidebar/src/sidebar-group-item.vue
@@ -11,6 +11,9 @@
:name="accordionName"
:icon="icon"
class="puik-sidebar-group-item__accordion"
+ :title-data-test="`${sidebarGroupItemDataTest}-title`"
+ :icon-data-test="`${sidebarGroupItemDataTest}-icon`"
+ :button-data-test="`${sidebarGroupItemDataTest}-button`"
>
@@ -20,6 +23,7 @@
variant="text"
fluid
class="puik-sidebar-group-item__collapsed-button"
+ :button-data-test="`${sidebarGroupItemDataTest}-button`"
>
diff --git a/packages/components/sidebar/src/sidebar-item.ts b/packages/components/sidebar/src/sidebar-item.ts
index b4b6a3df..881acf73 100644
--- a/packages/components/sidebar/src/sidebar-item.ts
+++ b/packages/components/sidebar/src/sidebar-item.ts
@@ -28,6 +28,11 @@ export const sidebarItemProps = buildProps({
required: false,
default: false,
},
+ sidebarItemDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
} as const)
export type SidebarItemProps = ExtractPropTypes
diff --git a/packages/components/sidebar/src/sidebar-item.vue b/packages/components/sidebar/src/sidebar-item.vue
index 6154de2c..af107456 100644
--- a/packages/components/sidebar/src/sidebar-item.vue
+++ b/packages/components/sidebar/src/sidebar-item.vue
@@ -13,6 +13,7 @@
fluid
variant="text"
class="puik-sidebar-item__button"
+ :button-data-test="`${sidebarItemDataTest}-menubuttonTitle`"
>
{{ title }}
@@ -27,8 +28,11 @@
:href="href"
fluid
variant="text"
+ :button-data-test="`${sidebarItemDataTest}-buttonTitle`"
>
- {{ title }}
+ {{
+ title
+ }}
diff --git a/packages/components/sidebar/src/sidebar-title.ts b/packages/components/sidebar/src/sidebar-title.ts
index 150192a3..f76bfb10 100644
--- a/packages/components/sidebar/src/sidebar-title.ts
+++ b/packages/components/sidebar/src/sidebar-title.ts
@@ -8,6 +8,11 @@ export const sidebarTitleProps = buildProps({
required: false,
default: 'h3',
},
+ sidebarTitleDataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
} as const)
export type SidebarTitleProps = ExtractPropTypes
diff --git a/packages/components/sidebar/src/sidebar-title.vue b/packages/components/sidebar/src/sidebar-title.vue
index cd87820d..2dd995ef 100644
--- a/packages/components/sidebar/src/sidebar-title.vue
+++ b/packages/components/sidebar/src/sidebar-title.vue
@@ -1,5 +1,10 @@
-
diff --git a/packages/components/sidebar/stories/sidebar-group-item.stories.ts b/packages/components/sidebar/stories/sidebar-group-item.stories.ts
index 65e9c308..82249000 100644
--- a/packages/components/sidebar/stories/sidebar-group-item.stories.ts
+++ b/packages/components/sidebar/stories/sidebar-group-item.stories.ts
@@ -52,6 +52,10 @@ export default {
control: 'none',
description: 'Set the defaut content slot',
},
+ sidebarGroupItemDataTest: {
+ control: 'text',
+ description: 'Set the data-test attribute on the sidebar group item',
+ },
},
args: {
title: 'title',
diff --git a/packages/components/sidebar/stories/sidebar-item.stories.ts b/packages/components/sidebar/stories/sidebar-item.stories.ts
index 4010960c..f1f8ac26 100644
--- a/packages/components/sidebar/stories/sidebar-item.stories.ts
+++ b/packages/components/sidebar/stories/sidebar-item.stories.ts
@@ -67,6 +67,10 @@ export default {
control: 'none',
description: 'Set the defaut content slot',
},
+ sidebarItemDataTest: {
+ control: 'text',
+ description: 'Set the data-test attribute on the item',
+ },
},
args: {
title: 'title',
diff --git a/packages/components/sidebar/stories/sidebar-title.stories.ts b/packages/components/sidebar/stories/sidebar-title.stories.ts
index b0cd3c3b..63f1bf46 100644
--- a/packages/components/sidebar/stories/sidebar-title.stories.ts
+++ b/packages/components/sidebar/stories/sidebar-title.stories.ts
@@ -30,6 +30,10 @@ export default {
},
},
},
+ sidebarTitleDataTest: {
+ control: 'text',
+ description: 'Set the data-test attribute on the sidebar title',
+ },
},
args: {
tag: 'h3',
From 983b26babff859926cb0411bd16efeb79ecbdcb9 Mon Sep 17 00:00:00 2001
From: Guillaume Lepoetre
Date: Mon, 30 Oct 2023 16:33:31 +0100
Subject: [PATCH 04/14] feat: Set data-test is to easy now
---
.../components/accordion/src/accordion.ts | 25 +++----------
.../components/accordion/src/accordion.vue | 8 ++--
.../accordion/stories/accordion.stories.ts | 20 +++-------
packages/components/alert/src/alert.ts | 20 +++-------
packages/components/alert/src/alert.vue | 10 +++--
.../components/alert/stories/alert.stories.ts | 15 ++------
packages/components/badge/src/badge.ts | 2 +-
packages/components/badge/src/badge.vue | 2 +-
.../components/badge/stories/badge.stories.ts | 3 +-
packages/components/button/src/button.ts | 12 +-----
packages/components/button/src/button.vue | 6 +--
.../button/stories/button.stories.ts | 16 ++------
packages/components/checkbox/src/checkbox.ts | 7 +---
packages/components/checkbox/src/checkbox.vue | 4 +-
.../checkbox/stories/checkbox.stories.ts | 10 ++---
packages/components/input/src/input.ts | 7 +---
packages/components/input/src/input.vue | 4 +-
.../components/input/stories/input.stories.ts | 10 ++---
.../components/menu/src/menu-item-title.ts | 2 +-
.../components/menu/src/menu-item-title.vue | 2 +-
.../menu/stories/menu-item-title.stories.ts | 4 +-
packages/components/modal/src/modal.ts | 22 +----------
packages/components/modal/src/modal.vue | 14 ++++---
.../components/modal/stories/modal.stories.ts | 30 +++------------
.../pagination/src/pagination-large.ts | 12 +-----
.../pagination/src/pagination-large.vue | 6 +--
.../pagination/src/pagination-loader.ts | 2 +-
.../pagination/src/pagination-loader.vue | 2 +-
.../pagination/src/pagination-medium.ts | 12 +-----
.../pagination/src/pagination-medium.vue | 6 +--
.../pagination/src/pagination-mobile.ts | 12 +-----
.../pagination/src/pagination-mobile.vue | 6 +--
.../pagination/src/pagination-small.ts | 12 +-----
.../pagination/src/pagination-small.vue | 6 +--
.../components/pagination/src/pagination.ts | 12 +-----
.../components/pagination/src/pagination.vue | 18 +++------
.../pagination/stories/pagination.stories.ts | 37 ++-----------------
.../src/progress-stepper-step.ts | 12 +-----
.../src/progress-stepper-step.vue | 9 +++--
.../stories/progress-stepper-step.stories.ts | 13 ++-----
packages/components/radio/src/radio.ts | 7 +---
packages/components/radio/src/radio.vue | 4 +-
.../components/radio/stories/radio.stories.ts | 11 ++----
packages/components/select/src/option.ts | 2 +-
packages/components/select/src/option.vue | 2 +-
packages/components/select/src/select.ts | 7 +---
packages/components/select/src/select.vue | 6 +--
.../select/stories/select.stories.ts | 19 ++--------
.../sidebar/src/sidebar-group-item.ts | 2 +-
.../sidebar/src/sidebar-group-item.vue | 6 +--
.../components/sidebar/src/sidebar-item.ts | 2 +-
.../components/sidebar/src/sidebar-item.vue | 8 ++--
.../components/sidebar/src/sidebar-title.ts | 2 +-
.../components/sidebar/src/sidebar-title.vue | 2 +-
.../stories/sidebar-group-item.stories.ts | 5 ++-
.../sidebar/stories/sidebar-item.stories.ts | 5 ++-
.../sidebar/stories/sidebar-title.stories.ts | 5 ++-
57 files changed, 141 insertions(+), 386 deletions(-)
diff --git a/packages/components/accordion/src/accordion.ts b/packages/components/accordion/src/accordion.ts
index 7ef6ac2f..bf71a2b1 100644
--- a/packages/components/accordion/src/accordion.ts
+++ b/packages/components/accordion/src/accordion.ts
@@ -7,46 +7,31 @@ export const accordionProps = buildProps({
type: String,
required: true,
},
- buttonDataTest: {
- type: String,
- required: false,
- default: undefined,
- },
title: {
type: String,
required: false,
default: undefined,
},
- titleDataTest: {
- type: String,
- required: false,
- default: undefined,
- },
subTitle: {
type: String,
required: false,
default: undefined,
},
- subTitleDataTest: {
- type: String,
- required: false,
- default: undefined,
- },
icon: {
type: String,
required: false,
default: undefined,
},
- iconDataTest: {
- type: String,
- required: false,
- default: undefined,
- },
disabled: {
type: Boolean,
required: false,
default: false,
},
+ dataTest: {
+ type: String,
+ required: false,
+ default: undefined,
+ },
} as const)
export const accordionEmits = ['click']
diff --git a/packages/components/accordion/src/accordion.vue b/packages/components/accordion/src/accordion.vue
index 6657a4ad..e3d1bdf4 100644
--- a/packages/components/accordion/src/accordion.vue
+++ b/packages/components/accordion/src/accordion.vue
@@ -11,7 +11,7 @@
:aria-controls="id"
class="puik-accordion__header"
:disabled="disabled"
- :data-test="buttonDataTest"
+ :data-test="`button-${dataTest}`"
@click="onClick"
>