Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into reducing the number of references to the OSD viewer #4023

Open
marlo-longley opened this issue Dec 9, 2024 · 0 comments
Open

Look into reducing the number of references to the OSD viewer #4023

marlo-longley opened this issue Dec 9, 2024 · 0 comments

Comments

@marlo-longley
Copy link
Member

Look into whether we can reduce the number of references to viewer and rely more on your new OpenSeadragonViewerContext. In my reading we have:

  • setViewer in the parent component's state that gets passed down
  • apiRef in the parent which is also holding a viewer and uses OSD methods like fitBounds
  • the viewerRef in the child OpenSeadragonComponent
  • also the viewer held in OpenSeadragonViewerContext

Something to think about (this also just helped me understand to write it out) -- and maybe for down the road not adding more work to this PR.

Originally posted by @marlo-longley in #4014 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marlo-longley