You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
The ShowTablesFrom for pgsql database type will return always the list for all the tables, not only the specific requested $databaseName. This code stays here:
return'SELECT table_name FROM information_schema.tables WHERE table_schema=\'' .
config("database.connections.pgsql.schema") .
'\' ORDER BY table_name;';
To Reproduce:
Go to home page
See the database tables list
Expected behavior:
Returns only the tables from the requested database. I'll suggest this change:
case "pgsql":
return'SELECT table_name FROM information_schema.tables WHERE ' .
'table_catalog=\'' . $databaseName . '\' AND ' .
'table_schema=\'' . config("database.connections.pgsql.schema") . '\'' .
'ORDER BY table_name;';
Test context:
Laravel 11
PHP 8.3
PostgreSQL database
Additional context:
The document doesn't talk about the config("database.connections.pgsql.schema") call in same method. I'll suggest to add this into the README or use the value public as a default value.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The ShowTablesFrom for pgsql database type will return always the list for all the tables, not only the specific requested
$databaseName
. This code stays here:Prequel/src/Database/SequelAdapter.php
Lines 91 to 94 in 9b37d8c
To Reproduce:
Expected behavior:
Returns only the tables from the requested database. I'll suggest this change:
Test context:
Additional context:
The document doesn't talk about the
config("database.connections.pgsql.schema")
call in same method. I'll suggest to add this into the README or use the valuepublic
as a default value.The text was updated successfully, but these errors were encountered: