Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tol variable used for 2 purpose: line search stop and inner solver stop #21

Open
josephsalmon opened this issue Sep 23, 2020 · 0 comments

Comments

@josephsalmon
Copy link
Collaborator

tol : float

In this line the tol variable is referenced as a criterion to stop the inner solver, though it is also used later on line 204:

if g_func <= g_func_old + C * tol + \

as a way to stop the line search. Both quantities are different, and may be introducing:
tol_ls and tol_inner_opt would be useful.
WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant