Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] AbstractFieldDefinition #58

Open
szabo137 opened this issue Dec 28, 2024 · 0 comments
Open

[Proposal] AbstractFieldDefinition #58

szabo137 opened this issue Dec 28, 2024 · 0 comments

Comments

@szabo137
Copy link
Member

szabo137 commented Dec 28, 2024

Currently, every AbstractPulsedPlaneWaveField must implement reference_momentum, which is plausible and should not be changed. However, there are circumstances, where the reference momentum is not needed, thus doesn't need to be specified. For instance, the envelope and amplitude function, and the generic spectrum only depend on phi (and fixed parameters) and not directly on the momentum. Even the full phase integrals depend on the kinematic parameters alpha, which are not necessarily calculated in the phase integrals itself.

Moreover, since some of these integrals require some data preparation (e.g. grids and adaptions), it would be not efficient to perform these actions for every possible reference momentum, even if this is not necessary.

Therefore, I propose to insert an abstraction layer, whose types only hold information about the field, like envelope, domain and parameters, but not the reference momentum. I suggest the abstract base type AbstractPulsedPlaneWaveFieldDefinition, and as interface functions: envelope and domain. The current AbstractPulsedPlaneWaveField could then be an extension (subtype) adding reference_momentum as an additional interface function.

Probably, we should discuss, where this abstraction layer should be inserted. Currently, the names become fairly long 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant