From bf0d12e3a3eacd65b1b6edd23afda442393f3235 Mon Sep 17 00:00:00 2001 From: Trey Stafford Date: Wed, 18 Dec 2024 09:04:54 -0700 Subject: [PATCH 1/2] Update default argo namespace from `argo-helm` to `qgnet` See also: https://github.com/QGreenland-Net/ogdc-argo/pull/7 --- src/ogdc_runner/argo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ogdc_runner/argo.py b/src/ogdc_runner/argo.py index d7ea893..b0839cc 100644 --- a/src/ogdc_runner/argo.py +++ b/src/ogdc_runner/argo.py @@ -31,7 +31,7 @@ def _configure_argo_settings() -> WorkflowsService: """ # set argo constants from envvars, falling back on dev settings - argo_namespace = os.environ.get("ARGO_NAMESPACE", "argo-helm") + argo_namespace = os.environ.get("ARGO_NAMESPACE", "qgnet") argo_service_account_name = os.environ.get( "ARGO_SERVICE_ACCOUNT_NAME", "argo-workflow" ) From 85a8179036d3a61c5dd08a150a72a970a10864a1 Mon Sep 17 00:00:00 2001 From: Trey Stafford Date: Wed, 18 Dec 2024 10:46:26 -0700 Subject: [PATCH 2/2] Update link in README --- docs/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 61cdbbc..1b5c2ac 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -7,7 +7,7 @@ description of best practices for developing scientific packages. ## Setting up a development environment manually -First, ensure you have [ogdc-argo](https://github.com/QGreenland-Net/ogdc-argo) +First, ensure you have [ogdc-helm](https://github.com/QGreenland-Net/ogdc-helm) setup for development. The argo server ports are expected to be forwarded for access via localhost.