Improve the performance #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! I homogenized the formatting a bit, but didn't make any semantical changes. Before I merge this: Is |
|
Good point, I just removed SparseArrays from the dependency. |
|
@jlbosse The CI failure seems to be irrelevant to this PR. |
|
Thanks for this! I merged and released a new version, so once JuliaRegistries/General#115689 is merged you should be able to get the new version from the General registry |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance can be improved a lot by writing the loops explicitly. These improvements are useful in my friend's project. @jlbosse Do you have time to get this PR reviewed?