Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure polyfun submodule gets installed #2

Open
bschilder opened this issue Jul 6, 2022 · 1 comment
Open

Make sure polyfun submodule gets installed #2

bschilder opened this issue Jul 6, 2022 · 1 comment
Assignees

Comments

@bschilder
Copy link
Member

bschilder commented Jul 6, 2022

The polyfun repo is not getting included in "inst/tools" when installing echofinemap.
This is because the submodule is being interpreted as an empty folder by R:
https://stackoverflow.com/questions/50474445/how-could-i-release-an-r-package-on-github-using-github-submodules

Suggested solution with packrat:
https://blog.methodsconsultants.com/posts/using-packrat-with-git-submodules/

Discussion on devtools:
r-lib/devtools#1163
r-lib/devtools#1222

git2r package:
https://github.com/ropensci/git2r

This function seems promising:
r-lib/devtools#751 (comment)

@bschilder
Copy link
Member Author

Intermediate solution: when users request to use PolyFun for the first time, they will have the option of re-installing echofinemap to add PolyFun. Not ideal, but it does work pretty consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant