Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Manager UI #1717

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Plugin Manager UI #1717

wants to merge 30 commits into from

Conversation

billz
Copy link
Member

@billz billz commented Dec 20, 2024 •
edited
Loading

Enumerates submodules from RaspAP's plugins repo, fetches manifests and displays basic details for available plugins on the System > Plugins tab.

Todo:

  • Parse manifest.json and perform plugin install actions
  • Create modal dialogs
  • Create PluginInstaller class to download + unpack user plugins

@billz billz linked an issue Dec 21, 2024 that may be closed by this pull request
Plugin Manager UI #1718
Open
billz added 18 commits December 20, 2024 18:52
@billz
Initial commit
247b35b
@billz
Call PluginInstaller::getInstance(), set install option
9b087f8
@billz
Initial commit
ee38614
@billz
Move getPluginManifest() to PluginInstaller class
6785cc1
@billz
Populate #install-user-plugin modal dialog
edb86d7
@billz
Encapsulate plugin related functions in PluginInstaller class
c3968ba
@billz
Create modal install-user-plugin dialog, update template text
2cb6666
@billz
Update w/ link to plugin_uri
e5987a6
@billz
Initial commit
44c99da
@billz
Add plugin install progress modal
efd67fb
@billz
Add visudo -cf, plugin_helper to sudoers
4328f54
@billz
Update w/ config, plugin actions
bf74ff7
@billz
Implement installPlugin() and related methods
bf0d9f8
@billz
Add _create_plugin_scripts()
759e5dc
@billz
Fix for getUserPlugins, add installed btn
2c0ace4
@billz
Update install-plugin-progress modal btn
ae7b038
@billz
Create plugin install event handler
92ba7df
@billz
Set/read plugin-installed flag
ad36695
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 26, 2024
View reviewed changes
app/js/custom.js Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 26, 2024
View reviewed changes
app/js/custom.js Dismissed Show dismissed Hide dismissed
@billz
Copy link
Member Author

billz commented Dec 27, 2024

Plugin-Installer

@billz
Copy link
Member Author

billz commented Jan 5, 2025

The class method getUserPlugins() iterates submodules in the plugins repo and fetches each plugin's manifest. This is executed with callbackTimeout() using a 2000ms value that permits the plugin installer to fail gracefully if the device has a slow or no internet connection. It could be improved later with an asynchronous operation and/or caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
@RaspAP's project
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin Manager UI
1 participant
@billz