Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove class member endpoint #417

Closed
2 tasks done
sra405 opened this issue Aug 21, 2024 · 2 comments · Fixed by #431 · May be fixed by #428
Closed
2 tasks done

Remove class member endpoint #417

sra405 opened this issue Aug 21, 2024 · 2 comments · Fixed by #431 · May be fixed by #428
Assignees
@conorriches

Comments

@sra405
Copy link
Contributor

sra405 commented Aug 21, 2024 •
edited by conorriches
Loading

  • add endpoint to remove class members from the table
  • audit the class members table due to this being the first instance of an edit
@conorriches conorriches self-assigned this Sep 5, 2024
@create-issue-branch Create Issue Branch
Copy link
Contributor

Branch issues/417-Remove_class_member_endpoint created!

create-issue-branch bot added a commit that referenced this issue Sep 5, 2024
@create-issue-branch
Create draft PR for #417
cee7806
@create-issue-branch create-issue-branch bot mentioned this issue Sep 5, 2024
Draft
@conorriches
Copy link
Member

Rough notes

When you delete student, in profile, the deleted_at flag is set
This causes a 422 from editor-api, as there is now a 404 from profile
The 404 happens because the student can't be found, but ID is requested by API
Student ID comes from class_members table
If we delete row from class_memebers table, it works. But do we want to delete or soft delete?

conorriches added a commit that referenced this issue Sep 10, 2024
@conorriches
add audit logging to class member table
ca2d8a8 
Closes #417

adds audit logging to class member table, using school ID meta field
@conorriches conorriches mentioned this issue Sep 10, 2024
Merged
conorriches added a commit that referenced this issue Sep 12, 2024
@conorriches
add audit logging to class member table (#431)
3b75752 
Closes #417

adds audit logging to class member table, using school ID meta field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorriches conorriches

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@conorriches @sra405