Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] feat/breaking prs should base off staging, ci should enforce #1499

Closed
bennypowers opened this issue Mar 14, 2024 · 0 comments · Fixed by #1500
Closed

[tools] feat/breaking prs should base off staging, ci should enforce #1499

bennypowers opened this issue Mar 14, 2024 · 0 comments · Fixed by #1500
Assignees

Comments

@bennypowers
Copy link
Member

We should run a CI step which checks for prs that include minor or major changesets, and if they do, that the PR targets a branch beginning with staging/, if it doesn't, the merge should be blocked and a comment posted in the PR thread.

While we're at it, we should check that if the the PR title begins with feat, it should have a minor changeset, and if it contains a !, it should have a major changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

1 participant