Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding WMS as Surface Throws Error #544

Open
philipbaileynar opened this issue Dec 12, 2024 · 1 comment
Open

Adding WMS as Surface Throws Error #544

philipbaileynar opened this issue Dec 12, 2024 · 1 comment
Assignees
Labels
🐛 bug Something isn't working

Comments

@philipbaileynar
Copy link
Contributor

This was observed in Logan this week....

Steps to Reproduce

  1. Right click on Surfaces in QRiS project tree and choose "Add New Surface"
  2. The QGIS data browser appears.
  3. Exapnd WMS and choose a web mapping service
  4. Back on the QRiS form, provide a name and pick a type etc...
  5. Click OK

Observed

See error screenshot.

Other Considerations

When fixing, please test adding a surface and the user picking from ANY of the many data ttypes in that tree.... Postgres Google Satellite etc.... We don't need to necessarily support all of these.... the software just needs to act gracefully warn the user and not crash.

Maybe we abandon the QGIS data browser and go with a File picker. I don't want to do this straight away and would rather explore whether we can filter the data browser down to the permissible data types etc.

PXL_20241211_222649476 MP

@KellyMWhitehead
Copy link
Collaborator

If the layer is not a 'gdal' compatible layer, then an Invalid Raster message will appear and prevent the user from importing the raster. This should catch any web/wms service rasters. Filtering to gdal rasters (includes most common file types, i.e. tif, gpkg) should prevent a lot of trouble, since we are using GDAL to make the copy anyway. If we come across a new or special type we need, then we will likely require special processing anyway.

Fixed for 1.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants