Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceManager instead of singleton #62

Open
JarvisCraft opened this issue Jun 2, 2020 · 0 comments
Open

Use ServiceManager instead of singleton #62

JarvisCraft opened this issue Jun 2, 2020 · 0 comments

Comments

@JarvisCraft
Copy link

Instead of sharing TransportPipesAPI via singleton instance initialized from constructor (which is also not very correct from point of JMM), this may be shared via Bukkit's ServicesManager which would allow better API design and possible future ability for splitting interfaces and their implementations.

If this gets supported, I may create a PR implementing this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JarvisCraft