Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: remove "= abap_true" when calling boolean methods #366

Open
vonglan opened this issue Oct 2, 2024 · 2 comments
Open

Feature Request: remove "= abap_true" when calling boolean methods #366

vonglan opened this issue Oct 2, 2024 · 2 comments

Comments

@vonglan
Copy link

vonglan commented Oct 2, 2024

Example:

      IF zcl_m_stock_transfer_order=>is_no_confirmation_necessary( i_reswk = i_line->supplyingPlant
                                                                   i_emwrk = i_line->ReceivingPlant ) = abap_true.

should convert to

      IF zcl_m_stock_transfer_order=>is_no_confirmation_necessary( i_reswk = i_line->supplyingPlant
                                                                   i_emwrk = i_line->ReceivingPlant ).

and maybe replace "= abap_false" in the same context with prefix NOT

@ConjuringCoffee
Copy link
Contributor

Please note that the ABAP Cleaner can only see the code that is open in the current editor. This rule could therefore only work for method definitions that exist in the current editor.

@vonglan
Copy link
Author

vonglan commented Nov 26, 2024

Ah, that reduces the usefulness (substantially, but not to zero)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants