Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for Connecting TF Resources #63

Open
1 task
sdischer-sap opened this issue Dec 12, 2024 · 0 comments
Open
1 task

Testing for Connecting TF Resources #63

sdischer-sap opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sdischer-sap
Copy link
Member

sdischer-sap commented Dec 12, 2024

Context

During the work on #53 we noticed that the code for connecting a tf resource to a ProviderConfig isn't being tested right now.
This refers to the two methods called TerraformSetupBuilder and TerraformSetupBuilderNoTracking (see here). While the first one is being used for any upjetted resource type the second one is being used specifically within ServiceManager and CloudManagement, where we have a native controller then internally delegates to a tf resource.
It probably makes sense to also combine those methods while we are at it. You can refer to similar tests like the ones for the rolecollection resource here.

Expected Outcome

  • TerraformSetupBuilder and TerraformSetupBuilderNoTracking are covered by unittests
@sdischer-sap sdischer-sap added good first issue Good for newcomers help wanted Extra attention is needed improvement labels Dec 12, 2024
@sdischer-sap sdischer-sap changed the title [INTERNAL] Add testing for Connecting TF Resources Add testing for Connecting TF Resources Dec 12, 2024
@sdischer-sap sdischer-sap changed the title Add testing for Connecting TF Resources Testing for Connecting TF Resources Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants