Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add instanceName and bindingName for CloudManagement CRD #73

Open
sdischer-sap opened this issue Dec 18, 2024 · 0 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sdischer-sap
Copy link
Member

sdischer-sap commented Dec 18, 2024

Is your feature request related to a problem? Please describe.
The Cloudmanagement resource currently uses medatdata.name as a name in BTP.
Since the metadata should be related only to k8s internal aspects thats not a good design choice. It also violates the idea of having everything payload-relevant in the spec.forProvider.
It also not really possible to import a resource without using the same name or letting it change it.

Describe the solution you'd like
It makes sense to follow the same approach as with the ServiceManager kind. It allows to specify an serviceInstanceName as well as a serviceBindingName. Those should be optional. If none is specified I would argue to use a static default value rather then the metadata.name. Same approach is used in the ServiceManager as well, so the implementation can be pretty much copied.

More precise requirements to meet

  • if from a schema endpoint only those two new optional values are added we can create a new v1alpha2 version. A Conversion should be done implicitly in this case
  • the implementation must be backwards compatible, meaning resources created with previous versions must reconcile successfully without doing any changes to resource, that needs to be tested at least manually
@sdischer-sap sdischer-sap added enhancement New feature or request help wanted Extra attention is needed labels Dec 18, 2024
@sdischer-sap sdischer-sap changed the title Add InstanceName and BindingName for CloudManagement CRD [FEATURE] Add InstanceName and BindingName for CloudManagement CRD Dec 18, 2024
@sdischer-sap sdischer-sap changed the title [FEATURE] Add InstanceName and BindingName for CloudManagement CRD [FEATURE] Add instanceName and bindingName for CloudManagement CRD Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant