Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(add AllowEmptyCommits to address breaking change ) #5251

Merged
merged 5 commits into from
Jan 28, 2025
Merged

chore(add AllowEmptyCommits to address breaking change ) #5251

merged 5 commits into from
Jan 28, 2025
+10 −6

Conversation

bitmaskit
Copy link
Contributor

@bitmaskit bitmaskit commented Jan 27, 2025 •
edited
Loading

Description

Addresses this comment -> #5220 (comment)

This PR technically includes a breaking change that artifactPrepareVersion needs to adapt to: https://redirect.github.com/go-git/go-git/pull/1050

Making empty commits will now fail, and artifactPrepareVersion for buildTool golang and cloud versioning tries to do that. To not fail, AllowEmptyCommits must be passed here...

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@bitmaskit bitmaskit requested a review from a team as a code owner January 27, 2025 16:55
@bitmaskit bitmaskit force-pushed the chore/update-artifactPrepareVersion branch from 2dd539d to 97e879b Compare January 27, 2025 17:12
@bitmaskit
Copy link
Contributor Author

/it-go

@bitmaskit bitmaskit enabled auto-merge (squash) January 27, 2025 17:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bitmaskit
Copy link
Contributor Author

/it-go

D074360
D074360 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@D074360 D074360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitmaskit bitmaskit merged commit 5796716 into master Jan 28, 2025
13 checks passed
@bitmaskit bitmaskit deleted the chore/update-artifactPrepareVersion branch January 28, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D074360 D074360 D074360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitmaskit @D074360