Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can Sign Up #17

Closed
samuelmenkus opened this issue Oct 14, 2019 · 3 comments
Closed

User can Sign Up #17

samuelmenkus opened this issue Oct 14, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@samuelmenkus
Copy link
Contributor

No description provided.

@josemvidal
Copy link
Member

The way issues work is

  • If you are are assigned to an issue, you have to do it.
  • Once you do it, you close the issue with a comment or, preferably, a link to your solution.

You should re-watch my teamwork lectures where I explain all this and more.

@rohanbsher
Copy link
Contributor

Sign up feature is working properly. User can sign up with our application and create a new account. They have to fill certain information like their username, email id, password etc. Signup with Facebook and Gmail will be implemented next semester.

@josemvidal
Copy link
Member

Ok.

Level up: for next semester:

When you close an issue by writing code, either fixing a bug or creating a new feature, you should add a link to the git-commit(s) that did it.

This can be done automatically if you just write "closes #X" in the comment of the git-commit, where X is the issue number you want to close. See closing issues using keywords for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants