Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a project as a reader, should not load MAE and MDP plugins #415

Closed
2 tasks done
geourjoa opened this issue Jan 22, 2025 · 4 comments · Fixed by #436
Closed
2 tasks done

Opening a project as a reader, should not load MAE and MDP plugins #415

geourjoa opened this issue Jan 22, 2025 · 4 comments · Fixed by #436
Assignees
@Drilio

Comments

@geourjoa
Copy link
Contributor

geourjoa commented Jan 22, 2025 •
edited
Loading

  • Check on the UI
  • Check in backend
@geourjoa geourjoa self-assigned this Jan 23, 2025
@geourjoa geourjoa linked a pull request Jan 24, 2025 that will close this issue
415 opening a worksspace as a reader should not load mae and mdp plugins #436
Merged
@geourjoa geourjoa mentioned this issue Jan 25, 2025
Merged
@geourjoa
Copy link
Contributor Author

geourjoa commented Jan 26, 2025 •
edited
Loading

This issue is indeed tricky.

If I have a project saved with MAEV window opened and I open it without plugin, I have the MAEV window displayed and usuable.

EDIT : I was not able to reproduce this tricky usecase. Perhaps a glitch of hot reload

@geourjoa geourjoa changed the title Opening a worksspace as a reader, should not load MAE and MDP plugins Opening a project as a reader, should not load MAE and MDP plugins Jan 26, 2025
@geourjoa
Copy link
Contributor Author

I tested project right gain from direct sharing or by groups. No issue.

@geourjoa
Copy link
Contributor Author

Wait review to be merged

@geourjoa
Copy link
Contributor Author

geourjoa commented Jan 27, 2025 •
edited
Loading

  • Hide save button when opened as reader
  • Disable automatic save. Toast say saving is ok but it was not. (Backend dont save and it's what we want)

@Drilio I Thinks it will be good if you finish this issue. Because you will see my refacto and check if it's ok to build on it

@geourjoa geourjoa assigned Drilio and unassigned geourjoa Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Drilio Drilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

415 opening a worksspace as a reader should not load mae and mdp plugins SCENE-CE/mirador-multi-user
2 participants
@Drilio @geourjoa