Fix #278: Provide all material to support multiple authentication scheme #359
+1,269
−7,079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineatstariongroup
requested review from
samatstariongroup and
lxatstariongroup
samatstariongroup
requested changes
Jan 29, 2025
| /// Retrieves all supported <see cref="AuthenticationSchemeKind" /> by the CDP4-COMET datasource | ||
| /// </summary> | ||
| /// <returns>An awaitable <see cref="Task{TResult}"/> that contains the value of the queried <see cref="AuthenticationSchemeResponse" /></returns> | ||
| public async Task<AuthenticationSchemeResponse> QueryAvailableAuthenticationScheme() |
There was a problem hiding this comment.
please add this method to the ISession interface
| // To test this, please enable one by one authentication scheme on the CDP4 COMET Server | ||
| public async Task VerifyCanAuthenticateWithMultipleSchemeAtDalLevel() | ||
| { | ||
| var authentitcatioCredentials = new Credentials(new Uri("http://localhost:5000/")); |
There was a problem hiding this comment.
I suppose a small typo
nathanatstariongroup
approved these changes
Jan 30, 2025
lxatstariongroup
approved these changes
Jan 30, 2025
CDP4Dal/Session.cs
Outdated
| /// <exception cref="InvalidOperationException">If all required <see cref="Credentials"/> informations are not provided</exception> | ||
| public async Task RefreshAuthenticationInformation() | ||
| { | ||
| if (this.Credentials.IsFullyInitiliazed) |
There was a problem hiding this comment.
Typo IsFullyInitiliazed => IsFullyInitialized
CDP4WspDal/CDP4WspDal.csproj
Outdated
There was a problem hiding this comment.
Was removing WSPDal on purpose?
There was a problem hiding this comment.
yes, agreed with @samatstariongroup
CDP4ServicesDal/CdpServicesDal.cs
Outdated
| @@ -881,6 +887,11 @@ public override async Task<IEnumerable<Thing>> Open(Credentials credentials, Can | |||
| throw new ArgumentNullException(nameof(credentials.Uri), $"The Credentials URI may not be null"); | |||
| } | |||
|
|
|||
| if (!credentials.IsFullyInitiliazed) | |||
| { | |||
| throw new ArgumentException("The Credentials is not be fully initiliazed"); | |||
There was a problem hiding this comment.
same typo on initiliazed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #278