Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide options for how svg icons are included in document #23

Closed
mattcoarr opened this issue Feb 7, 2014 · 1 comment
Closed

provide options for how svg icons are included in document #23

mattcoarr opened this issue Feb 7, 2014 · 1 comment
Labels
Pri-Low

Comments

@mattcoarr
Copy link
Contributor

allow three options for including svg logos:

  1. inline svg xml
  2. inline base64 encoded svg
  3. images via href urls

This would have two related benefits. First, if option 2 or 3 is enabled, the number of lines of html in the output would be shorter (the svg files can be long). This makes it easier to scan the html files.

Second, option 3 would make the html output a bit smaller. This supports issue #2.

We could give the user the option to choose between these three methods via a stylesheet parameter. Presumably, the current "inline svg xml" would be the default.
mattcoarr added a commit that referenced this issue Mar 5, 2014
@mattcoarr
updated the icon named templates to use a common named template with …
1b82fe8 
…different parameters.

supports issue #23
mattcoarr added a commit that referenced this issue Mar 5, 2014
@mattcoarr
switched to having the icon templates use a shared function
660c454 
also now the switch between iconReferenceStyle == "inlineLiteralXml" and iconReferenceStyle == "dataUri" is now working
  * data urs with base64 encoded svg data are now usable
  * inlineLiteralXml is the default

change also allows the stylesheet parameter to be passed in to the main stylesheet (stix-to-html.xsl) and used in the (now imported) icons.xsl

this supports issue #23
mattcoarr added a commit that referenced this issue Mar 5, 2014
@mattcoarr
now supporting iconReferenceStyle == "relativeUri"
7a16246 
also added parameter iconExternImageBaseUri that allows user to specify a relative or absolute uri to where the svg logo images are stored.

supports issue #23
mattcoarr added a commit that referenced this issue Mar 18, 2014
@mattcoarr
updated options for including svg images to fix paths used for includ…
97b2107 
…ing images inline (the old way) and via data uris (one of the two new options).

the paths used to read in the svg xml files needed the base "image/" parent directory.

this suppots issue #23
@mattcoarr
Copy link
Contributor Author

Now fixed. All three modes work as expected. This will be particularly useful if html reports are going to be served from a web server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pri-Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattcoarr