Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We reproduce your code and PSNR is far lower than your paper claimed. #75

Open
aabb-cc opened this issue Jul 1, 2022 · 2 comments
Open

Comments

@aabb-cc
Copy link

aabb-cc commented Jul 1, 2022

Hi, Longguang! Thanks for your interesting work and sharing your code! As we reproduce your code, the best PSNR results on Set14 as sigma=3.6 is 27.01 dB while what your paper claimed is 27.45 dB! I know your model can perform well as sigma is small. However, as the sigma become large, there is a big performance gap between our reproduced results and your paper giving results. My colleague also reproduce your code many times, but the same problems still exists!

image
image

The same problems seems proposed in the #38.
So can your tell me the error of our training command, shown as below? If there is no problem, for your academic reputation, I hope you reproduce your code again and evaluate your model on 4x Set14! Thanks!

training:
python main.py --dir_data='/media/datasets'
--model='blindsr'
--scale='4'
--blur_type='iso_gaussian'
--noise=0.0
--sig_min=0.2
--sig_max=4.0
--sig 3.6
--n_GPUs 2
test:
python test.py --test_only
--dir_data='/media/datasets'
--data_test='Set14'
--model='blindsr'
--scale='4'
--resume=600
--n_GPUs=1
--save 'test'
--blur_type='iso_gaussian'
--sig=3.6

@aabb-cc aabb-cc changed the title We reproduce your code and PSNR is 1 dB lower than your paper claimed. We reproduce your code and PSNR is far lower than your paper claimed. Jul 1, 2022
@jjlinghu
Copy link

jjlinghu commented Dec 4, 2022

I meet the same situation as you. Did you solve the problem, can you tell me how you do it, please!

@24324239
Copy link

I meet the same situation. Did you solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants