AG-1328: improve handling of target nominations table display strings #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hallieswan
commented
Apr 25, 2024
hallieswan
commented
- drop null study values from display string
- include all values from comma separated strings
…alues from comma separated strings
hallieswan
commented
Apr 25, 2024
Comment on lines
+43
to
+64
| const setUp = (genes: Gene[]) => { | ||
| const genesResponse: GenesResponse = { | ||
| items: genes | ||
| }; | ||
| mockApiService = TestBed.inject(ApiService); | ||
| spyOn(mockApiService, 'getNominatedGenes').and.returnValue( | ||
| of(genesResponse) | ||
| ); | ||
| fixture.detectChanges(); | ||
| element = fixture.nativeElement; | ||
|
|
||
| expect(mockApiService.getNominatedGenes).toHaveBeenCalled(); | ||
|
|
||
| const table = element.querySelector('table'); | ||
| expect(table).not.toBeNull(); | ||
|
|
||
| const rows = Array.from( | ||
| table?.querySelectorAll('tbody tr') || [] | ||
| ) as HTMLTableRowElement[]; | ||
|
|
||
| return { rows }; | ||
| }; |
There was a problem hiding this comment.
Create setUp method so that each test can specify which genes should be returned by the mock API service
hallieswan
commented
Apr 25, 2024
| ); | ||
| studyArray = de.target_nominations | ||
| .map((nt: TargetNomination) => nt.study) | ||
| .filter((item) => Boolean(item)) as string[]; |
There was a problem hiding this comment.
Fix for AG-1328 -- drop study values that are null or empty strings. See Cohort Study column below.
develop:
feature:
There was a problem hiding this comment.
as a suggestion, perhaps we can create a helper method to remove null/empty values .
There was a problem hiding this comment.
Done in the next commit
hallieswan
commented
Apr 25, 2024
src/app/features/genes/components/gene-nominated-targets/gene-nominated-targets.component.ts
Show resolved
Hide resolved
hallieswan
commented
Apr 25, 2024
src/app/features/genes/components/gene-nominated-targets/gene-nominated-targets.component.ts
Show resolved
Hide resolved
hallieswan
commented
Apr 25, 2024
src/app/features/genes/components/gene-nominated-targets/gene-nominated-targets.component.ts
Show resolved
Hide resolved
hallieswan
commented
Apr 25, 2024
src/app/features/genes/components/gene-nominated-targets/gene-nominated-targets.component.ts
Show resolved
Hide resolved
sagely1
reviewed
May 13, 2024
|
|
||
| return array; | ||
| formatDisplayValue(inputArray: string[]) { |
There was a problem hiding this comment.
As a suggestion, perhaps we can rename this to getCommaSeparatedString() or something similar to be a bit more descriptive.
There was a problem hiding this comment.
Good call, done in next commit!
sagely1
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.